| Message ID | 20181213104716.31930-20-hare@suse.de |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | ata: move DPRINTK to dynamic debugging | expand |
On 12/13/2018 01:47 PM, Hannes Reinecke wrote: > Replace all DPRINTK calls with the ata_XXX_dbg functions. > > Signed-off-by: Hannes Reinecke <hare@suse.com> > --- > drivers/ata/ahci.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index 021ce46e2e57..89d9980f3de4 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -698,7 +698,7 @@ static int ahci_vt8251_hardreset(struct ata_link *link, unsigned int *class, > bool online; > int rc; > > - DPRINTK("ENTER\n"); > + ata_link_dbg(link, "ENTER\n"); > > hpriv->stop_engine(ap); > > @@ -707,7 +707,7 @@ static int ahci_vt8251_hardreset(struct ata_link *link, unsigned int *class, > > hpriv->start_engine(ap); > > - DPRINTK("EXIT, rc=%d, class=%u\n", rc, *class); > + ata_link_dbg(link, "EXIT, rc=%d, class=%u\n", rc, *class); > > /* vt8251 doesn't clear BSY on signature FIS reception, > * request follow-up softreset. > @@ -788,7 +788,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class, > bool online; > int rc, i; > > - DPRINTK("ENTER\n"); > + ata_link_dbg(link, "ENTER\n"); > > hpriv->stop_engine(ap); > > @@ -828,7 +828,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class, > if (online) > *class = ahci_dev_classify(ap); > > - DPRINTK("EXIT, rc=%d, class=%u\n", rc, *class); > + ata_link_dbg(link, "EXIT, rc=%d, class=%u\n", rc, *class); > return rc; > } "ENTER"/"EXIT" without printing out __func__? MBR, Sergei
On 12/13/18 11:47 AM, Hannes Reinecke wrote: > Replace all DPRINTK calls with the ata_XXX_dbg functions. > > Signed-off-by: Hannes Reinecke <hare@suse.com> > --- > drivers/ata/ahci.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index 021ce46e2e57..89d9980f3de4 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -698,7 +698,7 @@ static int ahci_vt8251_hardreset(struct ata_link *link, unsigned int *class, > bool online; > int rc; > > - DPRINTK("ENTER\n"); > + ata_link_dbg(link, "ENTER\n"); Please preserve __func__ printing in the conversion. > hpriv->stop_engine(ap); > > @@ -707,7 +707,7 @@ static int ahci_vt8251_hardreset(struct ata_link *link, unsigned int *class, > > hpriv->start_engine(ap); > > - DPRINTK("EXIT, rc=%d, class=%u\n", rc, *class); > + ata_link_dbg(link, "EXIT, rc=%d, class=%u\n", rc, *class); ditto > /* vt8251 doesn't clear BSY on signature FIS reception, > * request follow-up softreset. > @@ -788,7 +788,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class, > bool online; > int rc, i; > > - DPRINTK("ENTER\n"); > + ata_link_dbg(link, "ENTER\n"); ditto > hpriv->stop_engine(ap); > > @@ -828,7 +828,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class, > if (online) > *class = ahci_dev_classify(ap); > > - DPRINTK("EXIT, rc=%d, class=%u\n", rc, *class); > + ata_link_dbg(link, "EXIT, rc=%d, class=%u\n", rc, *class); ditto > return rc; > } Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 021ce46e2e57..89d9980f3de4 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -698,7 +698,7 @@ static int ahci_vt8251_hardreset(struct ata_link *link, unsigned int *class, bool online; int rc; - DPRINTK("ENTER\n"); + ata_link_dbg(link, "ENTER\n"); hpriv->stop_engine(ap); @@ -707,7 +707,7 @@ static int ahci_vt8251_hardreset(struct ata_link *link, unsigned int *class, hpriv->start_engine(ap); - DPRINTK("EXIT, rc=%d, class=%u\n", rc, *class); + ata_link_dbg(link, "EXIT, rc=%d, class=%u\n", rc, *class); /* vt8251 doesn't clear BSY on signature FIS reception, * request follow-up softreset. @@ -788,7 +788,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class, bool online; int rc, i; - DPRINTK("ENTER\n"); + ata_link_dbg(link, "ENTER\n"); hpriv->stop_engine(ap); @@ -828,7 +828,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class, if (online) *class = ahci_dev_classify(ap); - DPRINTK("EXIT, rc=%d, class=%u\n", rc, *class); + ata_link_dbg(link, "EXIT, rc=%d, class=%u\n", rc, *class); return rc; }
Replace all DPRINTK calls with the ata_XXX_dbg functions. Signed-off-by: Hannes Reinecke <hare@suse.com> --- drivers/ata/ahci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)