mbox

[PULL,0/3] 9p patches 2018-12-13

Message ID 20181213090343.1137475-1-groug@kaod.org
State New
Headers show

Pull-request

https://github.com/gkurz/qemu.git tags/for-upstream

Message

Greg Kurz Dec. 13, 2018, 9:03 a.m. UTC 
The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:

  Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 19:18:58 +0000)

are available in the Git repository at:

  https://github.com/gkurz/qemu.git tags/for-upstream

for you to fetch changes up to 93aee84f575d46699f49af3c96194012527e0b22:

  9p: remove support for the "handle" backend (2018-12-12 14:18:10 +0100)

----------------------------------------------------------------
Most notable change in this PR is the full removal of the "handle" fsdev
backend.

----------------------------------------------------------------
Greg Kurz (3):
      9p: use g_new(T, n) instead of g_malloc(sizeof(T) * n)
      xen/9pfs: use g_new(T, n) instead of g_malloc(sizeof(T) * n)
      9p: remove support for the "handle" backend

 fsdev/qemu-fsdev.c       |   3 -
 hw/9pfs/9p-handle.c      | 710 -----------------------------------------------
 hw/9pfs/9p.c             |   4 +-
 hw/9pfs/Makefile.objs    |   1 -
 hw/9pfs/xen-9p-backend.c |   6 +-
 qemu-deprecated.texi     |   8 -
 qemu-options.hx          |   8 +-
 7 files changed, 9 insertions(+), 731 deletions(-)
 delete mode 100644 hw/9pfs/9p-handle.c

Comments

no-reply@patchew.org Dec. 13, 2018, 11:20 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20181213090343.1137475-1-groug@kaod.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20181213090343.1137475-1-groug@kaod.org
Subject: [Qemu-devel] [PULL 0/3] 9p patches 2018-12-13

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
error: RPC failed; result=18, HTTP code = 200
fatal: The remote end hung up unexpectedly
error: Could not fetch 3c8cf5a9c21ff8782164d1def7f44bd888713384
Traceback (most recent call last):
  File "patchew-tester/src/patchew-cli", line 521, in test_one
    git_clone_repo(clone, r["repo"], r["head"], logf, True)
  File "patchew-tester/src/patchew-cli", line 48, in git_clone_repo
    stdout=logf, stderr=logf)
  File "/usr/lib64/python3.4/subprocess.py", line 558, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'remote', 'add', '-f', '--mirror=fetch', '3c8cf5a9c21ff8782164d1def7f44bd888713384', 'https://github.com/patchew-project/qemu']' returned non-zero exit status 1



The full log is available at
http://patchew.org/logs/20181213090343.1137475-1-groug@kaod.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Greg Kurz Dec. 13, 2018, 12:04 p.m. UTC | #2 
On Thu, 13 Dec 2018 03:20:50 -0800 (PST)
no-reply@patchew.org wrote:

> Patchew URL: https://patchew.org/QEMU/20181213090343.1137475-1-groug@kaod.org/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Type: series
> Message-id: 20181213090343.1137475-1-groug@kaod.org
> Subject: [Qemu-devel] [PULL 0/3] 9p patches 2018-12-13
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> 
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
> 
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> 
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
>     echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
>         failed=1
>         echo
>     fi
>     n=$((n+1))
> done
> 
> exit $failed
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> error: RPC failed; result=18, HTTP code = 200
> fatal: The remote end hung up unexpectedly
> error: Could not fetch 3c8cf5a9c21ff8782164d1def7f44bd888713384

Huh... I really don't know where this SHA1 is coming from...

Fam, any idea what's going on here ?


> Traceback (most recent call last):
>   File "patchew-tester/src/patchew-cli", line 521, in test_one
>     git_clone_repo(clone, r["repo"], r["head"], logf, True)
>   File "patchew-tester/src/patchew-cli", line 48, in git_clone_repo
>     stdout=logf, stderr=logf)
>   File "/usr/lib64/python3.4/subprocess.py", line 558, in check_call
>     raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command '['git', 'remote', 'add', '-f', '--mirror=fetch', '3c8cf5a9c21ff8782164d1def7f44bd888713384', 'https://github.com/patchew-project/qemu']' returned non-zero exit status 1
> 
> 
> 
> The full log is available at
> http://patchew.org/logs/20181213090343.1137475-1-groug@kaod.org/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
Peter Maydell Dec. 14, 2018, 7:12 p.m. UTC | #3 
On Thu, 13 Dec 2018 at 09:03, Greg Kurz <groug@kaod.org> wrote:
>
> The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:
>
>   Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 19:18:58 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/gkurz/qemu.git tags/for-upstream
>
> for you to fetch changes up to 93aee84f575d46699f49af3c96194012527e0b22:
>
>   9p: remove support for the "handle" backend (2018-12-12 14:18:10 +0100)
>
> ----------------------------------------------------------------
> Most notable change in this PR is the full removal of the "handle" fsdev
> backend.
>
> ----------------------------------------------------------------
> Greg Kurz (3):
>       9p: use g_new(T, n) instead of g_malloc(sizeof(T) * n)
>       xen/9pfs: use g_new(T, n) instead of g_malloc(sizeof(T) * n)
>       9p: remove support for the "handle" backend

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM
Greg Kurz Dec. 15, 2018, 6:44 p.m. UTC | #4 
On Fri, 14 Dec 2018 19:12:07 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:

> On Thu, 13 Dec 2018 at 09:03, Greg Kurz <groug@kaod.org> wrote:
> >
> > The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:
> >
> >   Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 19:18:58 +0000)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/gkurz/qemu.git tags/for-upstream
> >
> > for you to fetch changes up to 93aee84f575d46699f49af3c96194012527e0b22:
> >
> >   9p: remove support for the "handle" backend (2018-12-12 14:18:10 +0100)
> >
> > ----------------------------------------------------------------
> > Most notable change in this PR is the full removal of the "handle" fsdev
> > backend.
> >
> > ----------------------------------------------------------------
> > Greg Kurz (3):
> >       9p: use g_new(T, n) instead of g_malloc(sizeof(T) * n)
> >       xen/9pfs: use g_new(T, n) instead of g_malloc(sizeof(T) * n)
> >       9p: remove support for the "handle" backend  
> 
> Applied, thanks.
> 
> Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
> for any user-visible changes.
> 

I've updated https://wiki.qemu.org/ChangeLog/4.0#Incompatible_changes
accordingly.

Cheers,

--
Greg

> -- PMM