gpio: aspeed: remove duplicated statement

Message ID 20181212215305.3852170-1-taoren@fb.com
State Not Applicable, archived
Headers show
Series
  • gpio: aspeed: remove duplicated statement
Related show

Commit Message

Tao Ren Dec. 12, 2018, 9:53 p.m.
Remove duplicated assignment statement from aspeed_gpio_probe() function.

Signed-off-by: Tao Ren <taoren@fb.com>
---
 drivers/gpio/gpio-aspeed.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Joel Stanley Dec. 13, 2018, 1:09 a.m. | #1
On Thu, 13 Dec 2018 at 08:24, Tao Ren <taoren@fb.com> wrote:
>
> Remove duplicated assignment statement from aspeed_gpio_probe() function.
>
> Signed-off-by: Tao Ren <taoren@fb.com>

Acked-by: Joel Stanley <joel@jms.id.au>

Thanks Tao!
Linus Walleij Dec. 21, 2018, 10:14 a.m. | #2
On Wed, Dec 12, 2018 at 10:53 PM Tao Ren <taoren@fb.com> wrote:

> Remove duplicated assignment statement from aspeed_gpio_probe() function.
>
> Signed-off-by: Tao Ren <taoren@fb.com>

Patch applied with Joel's ACK.

Yours,
Linus Walleij

Patch

diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index 2342e154029b..854bce4fb9e7 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1185,7 +1185,6 @@  static int __init aspeed_gpio_probe(struct platform_device *pdev)
 
 	gpio->chip.parent = &pdev->dev;
 	gpio->chip.ngpio = gpio->config->nr_gpios;
-	gpio->chip.parent = &pdev->dev;
 	gpio->chip.direction_input = aspeed_gpio_dir_in;
 	gpio->chip.direction_output = aspeed_gpio_dir_out;
 	gpio->chip.get_direction = aspeed_gpio_get_direction;