| Message ID | 20181212122330.347-1-brobecker@adacore.com |
|---|---|
| State | New |
| Headers | show |
| Series | [RFA] require profiling support for gcc.dg/lto/20100430-1_0.c test | expand |
On Wed, Dec 12, 2018 at 1:23 PM Joel Brobecker <brobecker@adacore.com> wrote: > > Hello, > > This test currently fails unexpectedly if GCC is configured with > --disable-gcov, because it requires -fprofile-arcs. This patch > fixes the issue by requiring profiling support in order to run > this test. > > Tested with two compilers, one built with --disable-gcov, resulting > in the test reporting an UNSUPPORTED result; and one built with gcov > support, resulting in 2 PASS tests. > > gcc/testsuite/ChangeLog: > > * gcc.dg/lto/20100430-1_0.c: Add dg-require-profiling requirement. > > OK to push? OK. > Thank you, > -- > Joel > > --- > gcc/testsuite/gcc.dg/lto/20100430-1_0.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gcc/testsuite/gcc.dg/lto/20100430-1_0.c b/gcc/testsuite/gcc.dg/lto/20100430-1_0.c > index 1ccfc9ac1ca..c7dafac31af 100644 > --- a/gcc/testsuite/gcc.dg/lto/20100430-1_0.c > +++ b/gcc/testsuite/gcc.dg/lto/20100430-1_0.c > @@ -1,6 +1,7 @@ > /* { dg-lto-do link } */ > /* { dg-lto-options {{-O2 -fprofile-arcs -flto -r -nostdlib}} } */ > /* { dg-extra-ld-options "-flinker-output=nolto-rel" } */ > +/* { dg-require-profiling "-fprofile-arcs" } */ > > > void > -- > 2.17.1 >
> > gcc/testsuite/ChangeLog: > > > > * gcc.dg/lto/20100430-1_0.c: Add dg-require-profiling requirement. > > > > OK to push? > > OK. Thank you Richard. Patch pushed to trunk (r267055).
diff --git a/gcc/testsuite/gcc.dg/lto/20100430-1_0.c b/gcc/testsuite/gcc.dg/lto/20100430-1_0.c index 1ccfc9ac1ca..c7dafac31af 100644 --- a/gcc/testsuite/gcc.dg/lto/20100430-1_0.c +++ b/gcc/testsuite/gcc.dg/lto/20100430-1_0.c @@ -1,6 +1,7 @@ /* { dg-lto-do link } */ /* { dg-lto-options {{-O2 -fprofile-arcs -flto -r -nostdlib}} } */ /* { dg-extra-ld-options "-flinker-output=nolto-rel" } */ +/* { dg-require-profiling "-fprofile-arcs" } */ void
Hello, This test currently fails unexpectedly if GCC is configured with --disable-gcov, because it requires -fprofile-arcs. This patch fixes the issue by requiring profiling support in order to run this test. Tested with two compilers, one built with --disable-gcov, resulting in the test reporting an UNSUPPORTED result; and one built with gcov support, resulting in 2 PASS tests. gcc/testsuite/ChangeLog: * gcc.dg/lto/20100430-1_0.c: Add dg-require-profiling requirement. OK to push? Thank you,