From patchwork Tue Dec 11 22:46:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonardo Sandoval X-Patchwork-Id: 1011412 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-98244-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="ABToJ3TR"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43Dw7D0rRBz9s3l for ; Wed, 12 Dec 2018 09:47:19 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; q=dns; s= default; b=aiSva4xaMMMOe8WfRifYmguFdEfSJ46DiJXQrJP/pGKwfNU2Vd07j LB5+SE2Ew3OtPdrVOgctof6DLpZYXeZXDS0aQlEnVABr95PtjqwD0DggarD3D/Um sVmL0gEOl4OBASauq/1iRlDs15+TCiUYaHYrp8dmlHuEFTgG62AM+Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; s=default; bh=R4gqAKxTGbmlVYpsXHi4kq2M3is=; b=ABToJ3TRXFvik8jM15Kkv9RI7RnR rHTruOFSKzdnmRahWh727RpbjACyiwmQrVQzjHyOHcbMbC8eshLTyZlU/g7nRN94 6dhNqp5a2/Epv9xidBXN++9WhbQGKuvW8z0qZcYGNL7U27G4VPIsxg8y92KHkebp qgUYGaWqb4Cv3UM= Received: (qmail 45871 invoked by alias); 11 Dec 2018 22:47:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 45749 invoked by uid 89); 11 Dec 2018 22:47:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=processed, HContent-Transfer-Encoding:8bit X-HELO: mga11.intel.com From: leonardo.sandoval.gonzalez@linux.intel.com To: libc-alpha@sourceware.org Cc: Leonardo Sandoval Subject: [PATCH v2 1/3] benchtests: keep comparing even if function timings do not match Date: Tue, 11 Dec 2018 16:46:57 -0600 Message-Id: <20181211224659.29876-2-leonardo.sandoval.gonzalez@linux.intel.com> In-Reply-To: <20181211224659.29876-1-leonardo.sandoval.gonzalez@linux.intel.com> References: <20181211224659.29876-1-leonardo.sandoval.gonzalez@linux.intel.com> MIME-Version: 1.0 From: Leonardo Sandoval Allows other functions to be processed, making the script a bit more fault tolerant thus useful. * benchtests/scripts/compare_bench.py (compare_runs): Continue instead of return. --- benchtests/scripts/compare_bench.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchtests/scripts/compare_bench.py b/benchtests/scripts/compare_bench.py index f4b7742f90..9cbbda6be6 100755 --- a/benchtests/scripts/compare_bench.py +++ b/benchtests/scripts/compare_bench.py @@ -77,7 +77,7 @@ def compare_runs(pts1, pts2, threshold): # timing info for the function variant. if 'timings' not in pts1['functions'][func][var].keys() or \ 'timings' not in pts2['functions'][func][var].keys(): - return + continue # If two lists do not have the same length then it is likely that # the performance characteristics of the function have changed.