From patchwork Mon Jun 20 11:15:22 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 101093 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 793F5B6FE1 for ; Mon, 20 Jun 2011 21:15:42 +1000 (EST) Received: (qmail 30399 invoked by alias); 20 Jun 2011 11:15:40 -0000 Received: (qmail 30390 invoked by uid 22791); 20 Jun 2011 11:15:40 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Jun 2011 11:15:26 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 561E08A5; Mon, 20 Jun 2011 13:15:25 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Cg5RABdQg7+E; Mon, 20 Jun 2011 13:15:23 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 779A08A4; Mon, 20 Jun 2011 13:15:23 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id p5KBFMmr018383; Mon, 20 Jun 2011 13:15:22 +0200 (MEST) From: Rainer Orth To: gcc-patches@gcc.gnu.org Cc: Arnaud Charlet Subject: [ada, build] Link gnattools with $(LIBINTL) Date: Mon, 20 Jun 2011 13:15:22 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On several platforms (e.g. Solaris 10/x86), several gnattools fail to link: Undefined first referenced symbol in file libintl_gettext ../../libcommon.a(diagnostic.o) libintl_textdomain ../../libcommon.a(intl.o) libintl_bindtextdomain ../../libcommon.a(intl.o) libintl_ngettext ../../libcommon.a(diagnostic.o) ld: fatal: Symbol referencing errors. No output written to ../../gnatmake collect2: error: ld returned 1 exit status libcommon.a may depend on libintl.a, but that is missing from $(TOOLS_LIBS). The following patch corrects this and allows bootstrap to finish successfully on i386-pc-solaris2.10. Ok for mainline? I suppose this is obvious. Thanks. Rainer 2011-06-17 Rainer Orth * gcc-interface/Makefile.in (TOOLS_LIBS): Add $(LIBINTL). diff --git a/gcc/ada/gcc-interface/Makefile.in b/gcc/ada/gcc-interface/Makefile.in --- a/gcc/ada/gcc-interface/Makefile.in +++ b/gcc/ada/gcc-interface/Makefile.in @@ -1,5 +1,5 @@ # Makefile for GNU Ada Compiler (GNAT). -# Copyright (C) 1994-2010 Free Software Foundation, Inc. +# Copyright (C) 1994-2011 Free Software Foundation, Inc. #This file is part of GCC. @@ -246,7 +246,7 @@ LIBS = $(LIBINTL) $(LIBIBERTY) $(SYSLIBS LIBDEPS = $(LIBINTL_DEP) $(LIBIBERTY) # Default is no TGT_LIB; one might be passed down or something TGT_LIB = -TOOLS_LIBS = $(EXTRA_GNATTOOLS_OBJS) targext.o link.o $(LIBGNAT) ../../../libiberty/libiberty.a $(SYSLIBS) $(TGT_LIB) +TOOLS_LIBS = $(EXTRA_GNATTOOLS_OBJS) targext.o link.o $(LIBGNAT) $(LIBINTL) ../../../libiberty/libiberty.a $(SYSLIBS) $(TGT_LIB) # Convert the target variable into a space separated list of architecture, # manufacturer, and operating system and assign each of those to its own