pinctrl: aspeed: Wrap -Woverride-init with cc-option

Message ID 20181211000506.7559-1-natechancellor@gmail.com
State Not Applicable, archived
Headers show
Series
  • pinctrl: aspeed: Wrap -Woverride-init with cc-option
Related show

Commit Message

Nathan Chancellor Dec. 11, 2018, 12:05 a.m.
Clang does not support this option:

warning: unknown warning option '-Woverride-init'; did you mean
'-Woverride-module'? [-Wunknown-warning-option]
1 warning generated.

Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
 drivers/pinctrl/aspeed/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joel Stanley Dec. 11, 2018, 12:16 a.m. | #1
On Tue, 11 Dec 2018 at 10:40, Andrew Jeffery <andrew@aj.id.au> wrote:
>
>
>
> On Tue, 11 Dec 2018, at 10:35, Nathan Chancellor wrote:
> > Clang does not support this option:
> >
> > warning: unknown warning option '-Woverride-init'; did you mean
> > '-Woverride-module'? [-Wunknown-warning-option]
> > 1 warning generated.
> >
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>
> Acked-by: Andrew Jeffery <andrew@aj.id.au>

Thanks Nathan.

Andrew explained to me that this warning helps find bugs when
developing the complicated (some would say crazy) set of macros that
this pinctrl driver uses. It would be good to have this warning
available in clang. Do we have a clang issue opened for that?

Acked-by: Joel Stanley <joel@jms.id.au>

Cheers,

Joel
Nathan Chancellor Dec. 11, 2018, 12:25 a.m. | #2
On Tue, Dec 11, 2018 at 10:46:26AM +1030, Joel Stanley wrote:
> On Tue, 11 Dec 2018 at 10:40, Andrew Jeffery <andrew@aj.id.au> wrote:
> >
> >
> >
> > On Tue, 11 Dec 2018, at 10:35, Nathan Chancellor wrote:
> > > Clang does not support this option:
> > >
> > > warning: unknown warning option '-Woverride-init'; did you mean
> > > '-Woverride-module'? [-Wunknown-warning-option]
> > > 1 warning generated.
> > >
> > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> >
> > Acked-by: Andrew Jeffery <andrew@aj.id.au>
> 
> Thanks Nathan.
> 
> Andrew explained to me that this warning helps find bugs when
> developing the complicated (some would say crazy) set of macros that
> this pinctrl driver uses. It would be good to have this warning
> available in clang. Do we have a clang issue opened for that?
> 
> Acked-by: Joel Stanley <joel@jms.id.au>
> 
> Cheers,
> 
> Joel

Hi Joel,

I just opened https://github.com/ClangBuiltLinux/linux/issues/293.

I searched the LLVM issue tracker and haven't see any reference of this.
I can file an issue but if you are a little more familiar with this
warning, you are welcome to do it instead.

Thanks for the quick response,
Nathan
Linus Walleij Dec. 16, 2018, 12:23 a.m. | #3
On Tue, Dec 11, 2018 at 1:05 AM Nathan Chancellor
<natechancellor@gmail.com> wrote:

> Clang does not support this option:
>
> warning: unknown warning option '-Woverride-init'; did you mean
> '-Woverride-module'? [-Wunknown-warning-option]
> 1 warning generated.
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Patch applied with the ACKs!

Yours,
Linus Walleij

Patch

diff --git a/drivers/pinctrl/aspeed/Makefile b/drivers/pinctrl/aspeed/Makefile
index 191ed0fc1804..790b406aae19 100644
--- a/drivers/pinctrl/aspeed/Makefile
+++ b/drivers/pinctrl/aspeed/Makefile
@@ -1,6 +1,6 @@ 
 # Aspeed pinctrl support
 
-ccflags-y += -Woverride-init
+ccflags-y += $(call cc-option,-Woverride-init)
 obj-$(CONFIG_PINCTRL_ASPEED)	+= pinctrl-aspeed.o
 obj-$(CONFIG_PINCTRL_ASPEED_G4)	+= pinctrl-aspeed-g4.o
 obj-$(CONFIG_PINCTRL_ASPEED_G5)	+= pinctrl-aspeed-g5.o