| Message ID | 20181210222718.19926-1-ndesaulniers@google.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | x86/um/vdso: Drop implicit common-page-size linker flag | expand |
Am Montag, 10. Dezember 2018, 23:27:16 CET schrieb ndesaulniers@google.com: > GNU linker's -z common-page-size's default value is based on the target > architecture. arch/x86/entry/vdso/Makefile sets it to the architecture > default, which is implicit and redundant. Drop it. > > Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- > arch/x86/um/vdso/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile > index 822ccdba93ad..bf94060fc06f 100644 > --- a/arch/x86/um/vdso/Makefile > +++ b/arch/x86/um/vdso/Makefile > @@ -26,7 +26,7 @@ targets += vdso.so vdso.so.dbg vdso.lds $(vobjs-y) > CPPFLAGS_vdso.lds += -P -C > > VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \ > - -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 > + -Wl,-z,max-page-size=4096 Acked-by: Richard Weinberger <richard@nod.at> Thanks, //richard
diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile index 822ccdba93ad..bf94060fc06f 100644 --- a/arch/x86/um/vdso/Makefile +++ b/arch/x86/um/vdso/Makefile @@ -26,7 +26,7 @@ targets += vdso.so vdso.so.dbg vdso.lds $(vobjs-y) CPPFLAGS_vdso.lds += -P -C VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \ - -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 + -Wl,-z,max-page-size=4096 $(obj)/vdso.o: $(src)/vdso.S $(obj)/vdso.so
GNU linker's -z common-page-size's default value is based on the target architecture. arch/x86/entry/vdso/Makefile sets it to the architecture default, which is implicit and redundant. Drop it. Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- arch/x86/um/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)