ARM: dts: aspeed: Add KCS support for LPC BMC

Message ID 20181210200753.3018124-2-vijaykhemka@fb.com
State Not Applicable, archived
Headers show
Series
  • ARM: dts: aspeed: Add KCS support for LPC BMC
Related show

Commit Message

Vijay Khemka Dec. 10, 2018, 8:07 p.m.
Added kcs device support for lpc BMC.

Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
 arch/arm/boot/dts/aspeed-g5.dtsi | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

Comments

Vijay Khemka Dec. 10, 2018, 10:39 p.m. | #1
Please ignore this patch as it is duplicate. It is included in list of 2 patches I have sent just before.

´╗┐On 12/10/18, 12:08 PM, "Vijay Khemka" <vijaykhemka@fb.com> wrote:

    Added kcs device support for lpc BMC.
    
    Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
    ---
     arch/arm/boot/dts/aspeed-g5.dtsi | 29 ++++++++++++++++++++++++++++-
     1 file changed, 28 insertions(+), 1 deletion(-)
    
    diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
    index d107459fc0f8..1bd48655bacb 100644
    --- a/arch/arm/boot/dts/aspeed-g5.dtsi
    +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
    @@ -330,8 +330,35 @@
     				ranges = <0x0 0x1e789000 0x1000>;
     
     				lpc_bmc: lpc-bmc@0 {
    -					compatible = "aspeed,ast2500-lpc-bmc";
    +					compatible = "aspeed,ast2500-lpc-bmc, "simple-mfd", "syscon"";
     					reg = <0x0 0x80>;
    +					reg-io-width = <4>;
    +
    +					#address-cells = <1>;
    +					#size-cells = <1>;
    +					ranges = <0x0 0x0 0x80>;
    +
    +					kcs1: kcs1@0 {
    +						compatible = "aspeed,ast2500-kcs-bmc";
    +						reg = <0x0 0x80>;
    +						interrupts = <8>;
    +						kcs_chan = <1>;
    +						status = "disabled";
    +					};
    +					kcs2: kcs2@0 {
    +						compatible = "aspeed,ast2500-kcs-bmc";
    +						reg = <0x0 0x80>;
    +						interrupts = <8>;
    +						kcs_chan = <2>;
    +						status = "disabled";
    +					};
    +					kcs3: kcs3@0 {
    +						compatible = "aspeed,ast2500-kcs-bmc";
    +						reg = <0x0 0x80>;
    +						interrupts = <8>;
    +						kcs_chan = <3>;
    +						status = "disabled";
    +					};
     				};
     
     				lpc_host: lpc-host@80 {
    -- 
    2.17.1
kbuild test robot Dec. 16, 2018, 8:13 a.m. | #2
Hi Vijay,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on joel-aspeed/for-next]
[also build test ERROR on v4.20-rc6 next-20181214]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vijay-Khemka/ARM-dts-aspeed-Add-KCS-support-for-LPC-BMC/20181211-074230
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git for-next
config: arm-multi_v5_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/aspeed-g5.dtsi:333.45-46 syntax error
   FATAL ERROR: Unable to parse input tree

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Patch

diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index d107459fc0f8..1bd48655bacb 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -330,8 +330,35 @@ 
 				ranges = <0x0 0x1e789000 0x1000>;
 
 				lpc_bmc: lpc-bmc@0 {
-					compatible = "aspeed,ast2500-lpc-bmc";
+					compatible = "aspeed,ast2500-lpc-bmc, "simple-mfd", "syscon"";
 					reg = <0x0 0x80>;
+					reg-io-width = <4>;
+
+					#address-cells = <1>;
+					#size-cells = <1>;
+					ranges = <0x0 0x0 0x80>;
+
+					kcs1: kcs1@0 {
+						compatible = "aspeed,ast2500-kcs-bmc";
+						reg = <0x0 0x80>;
+						interrupts = <8>;
+						kcs_chan = <1>;
+						status = "disabled";
+					};
+					kcs2: kcs2@0 {
+						compatible = "aspeed,ast2500-kcs-bmc";
+						reg = <0x0 0x80>;
+						interrupts = <8>;
+						kcs_chan = <2>;
+						status = "disabled";
+					};
+					kcs3: kcs3@0 {
+						compatible = "aspeed,ast2500-kcs-bmc";
+						reg = <0x0 0x80>;
+						interrupts = <8>;
+						kcs_chan = <3>;
+						status = "disabled";
+					};
 				};
 
 				lpc_host: lpc-host@80 {