[U-Boot,1/2] configs: igep: Define default mtdids/mtdparts
diff mbox series

Message ID 20181210153850.3272-1-boris.brezillon@bootlin.com
State Needs Review / ACK
Delegated to: Tom Rini
Headers show
Series
  • [U-Boot,1/2] configs: igep: Define default mtdids/mtdparts
Related show

Commit Message

Boris Brezillon Dec. 10, 2018, 3:38 p.m. UTC
We are trying to get rid of the weak board_mtdparts_default() function
and we need to make sure igep defconfigs have proper proper
CONFIG_MTD{IDS,PARTS}_DEFAULT before doing that.

Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
 configs/igep0032_defconfig | 2 ++
 configs/igep00x0_defconfig | 2 ++
 2 files changed, 4 insertions(+)

Comments

Enric Balletbo Serra Dec. 10, 2018, 9:50 p.m. UTC | #1
+Ladis who might be also interested.
Missatge de Boris Brezillon <boris.brezillon@bootlin.com> del dia dl.,
10 de des. 2018 a les 16:38:
>
> We are trying to get rid of the weak board_mtdparts_default() function
> and we need to make sure igep defconfigs have proper proper
> CONFIG_MTD{IDS,PARTS}_DEFAULT before doing that.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
>  configs/igep0032_defconfig | 2 ++
>  configs/igep00x0_defconfig | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/configs/igep0032_defconfig b/configs/igep0032_defconfig
> index 383648789c53..d2a614c98f6d 100644
> --- a/configs/igep0032_defconfig
> +++ b/configs/igep0032_defconfig
> @@ -28,6 +28,8 @@ CONFIG_CMD_SPI=y
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_EXT4_WRITE=y
>  CONFIG_CMD_MTDPARTS=y
> +CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand,onenand0=omap2-onenand"
> +CONFIG_MTDPARTS_DEFAULT="omap2-nand:512k(SPL),-(UBI);omap2-onenand:512k(SPL),-(UBI)"
>  CONFIG_CMD_UBI=y
>  # CONFIG_CMD_UBIFS is not set
>  CONFIG_NET_RANDOM_ETHADDR=y
> diff --git a/configs/igep00x0_defconfig b/configs/igep00x0_defconfig
> index f2989e34e12e..5d3e109ee3c2 100644
> --- a/configs/igep00x0_defconfig
> +++ b/configs/igep00x0_defconfig
> @@ -28,6 +28,8 @@ CONFIG_CMD_SPI=y
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_EXT4_WRITE=y
>  CONFIG_CMD_MTDPARTS=y
> +CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand,onenand0=omap2-onenand"
> +CONFIG_MTDPARTS_DEFAULT="omap2-nand:512k(SPL),-(UBI);omap2-onenand:512k(SPL),-(UBI)"
>  CONFIG_CMD_UBI=y
>  # CONFIG_CMD_UBIFS is not set
>  CONFIG_NET_RANDOM_ETHADDR=y
> --
> 2.17.1
>
Enric Balletbo Serra Dec. 21, 2018, 10:22 a.m. UTC | #2
Hi Boris,

Missatge de Enric Balletbo Serra <eballetbo@gmail.com> del dia dl., 10
de des. 2018 a les 22:50:
>
> +Ladis who might be also interested.
> Missatge de Boris Brezillon <boris.brezillon@bootlin.com> del dia dl.,
> 10 de des. 2018 a les 16:38:
> >
> > We are trying to get rid of the weak board_mtdparts_default() function
> > and we need to make sure igep defconfigs have proper proper
> > CONFIG_MTD{IDS,PARTS}_DEFAULT before doing that.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> > ---
> >  configs/igep0032_defconfig | 2 ++
> >  configs/igep00x0_defconfig | 2 ++
> >  2 files changed, 4 insertions(+)
> >
> > diff --git a/configs/igep0032_defconfig b/configs/igep0032_defconfig
> > index 383648789c53..d2a614c98f6d 100644
> > --- a/configs/igep0032_defconfig
> > +++ b/configs/igep0032_defconfig
> > @@ -28,6 +28,8 @@ CONFIG_CMD_SPI=y
> >  CONFIG_CMD_CACHE=y
> >  CONFIG_CMD_EXT4_WRITE=y
> >  CONFIG_CMD_MTDPARTS=y
> > +CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand,onenand0=omap2-onenand"
> > +CONFIG_MTDPARTS_DEFAULT="omap2-nand:512k(SPL),-(UBI);omap2-onenand:512k(SPL),-(UBI)"
> >  CONFIG_CMD_UBI=y
> >  # CONFIG_CMD_UBIFS is not set
> >  CONFIG_NET_RANDOM_ETHADDR=y
> > diff --git a/configs/igep00x0_defconfig b/configs/igep00x0_defconfig
> > index f2989e34e12e..5d3e109ee3c2 100644
> > --- a/configs/igep00x0_defconfig
> > +++ b/configs/igep00x0_defconfig
> > @@ -28,6 +28,8 @@ CONFIG_CMD_SPI=y
> >  CONFIG_CMD_CACHE=y
> >  CONFIG_CMD_EXT4_WRITE=y
> >  CONFIG_CMD_MTDPARTS=y
> > +CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand,onenand0=omap2-onenand"
> > +CONFIG_MTDPARTS_DEFAULT="omap2-nand:512k(SPL),-(UBI);omap2-onenand:512k(SPL),-(UBI)"
> >  CONFIG_CMD_UBI=y
> >  # CONFIG_CMD_UBIFS is not set
> >  CONFIG_NET_RANDOM_ETHADDR=y
> > --
> > 2.17.1
> >

After do some tests, the patch lgtm

Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Patch
diff mbox series

diff --git a/configs/igep0032_defconfig b/configs/igep0032_defconfig
index 383648789c53..d2a614c98f6d 100644
--- a/configs/igep0032_defconfig
+++ b/configs/igep0032_defconfig
@@ -28,6 +28,8 @@  CONFIG_CMD_SPI=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_MTDPARTS=y
+CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand,onenand0=omap2-onenand"
+CONFIG_MTDPARTS_DEFAULT="omap2-nand:512k(SPL),-(UBI);omap2-onenand:512k(SPL),-(UBI)"
 CONFIG_CMD_UBI=y
 # CONFIG_CMD_UBIFS is not set
 CONFIG_NET_RANDOM_ETHADDR=y
diff --git a/configs/igep00x0_defconfig b/configs/igep00x0_defconfig
index f2989e34e12e..5d3e109ee3c2 100644
--- a/configs/igep00x0_defconfig
+++ b/configs/igep00x0_defconfig
@@ -28,6 +28,8 @@  CONFIG_CMD_SPI=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_MTDPARTS=y
+CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand,onenand0=omap2-onenand"
+CONFIG_MTDPARTS_DEFAULT="omap2-nand:512k(SPL),-(UBI);omap2-onenand:512k(SPL),-(UBI)"
 CONFIG_CMD_UBI=y
 # CONFIG_CMD_UBIFS is not set
 CONFIG_NET_RANDOM_ETHADDR=y