Patchwork ubifs: dereferencing an ERR_PTR in ubifs_mount()

login
register
mail settings
Submitter Dan Carpenter
Date June 20, 2011, 7:10 a.m.
Message ID <20110620071024.GF14591@shale.localdomain>
Download mbox | patch
Permalink /patch/101040/
State Accepted
Commit 185bf87393afe6b966881e36c459949d90930a7a
Headers show

Comments

Dan Carpenter - June 20, 2011, 7:10 a.m.
d251ed271d5 "ubifs: fix sget races" left out the goto from this
error path so the static checkers complain that we're dereferencing
"sb" when it's an ERR_PTR.

Signed-off-by: Dan Carpenter <error27@gmail.com>

Patch

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 8c892c2..529be05 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -2146,6 +2146,7 @@  static struct dentry *ubifs_mount(struct file_system_type *fs_type, int flags,
 	if (IS_ERR(sb)) {
 		err = PTR_ERR(sb);
 		kfree(c);
+		goto out_close;
 	}
 
 	if (sb->s_root) {