| Message ID | b579be009e0a310f69f0c7da311610472829cad2.1544369598.git.chunkeey@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [OpenWrt-Devel,1/8] kernel: add DT binding support to the fit parser | expand |
On Sunday, December 9, 2018 4:57:10 PM CET INAGAKI Hiroshi wrote: > On 2018/12/10 0:34, Christian Lamparter wrote: > > Specify firmware partition format by compatible string. > > > > Cc: INAGAKI Hiroshi <musashino.open@gmail.com> > > Signed-off-by: Christian Lamparter <chunkeey@gmail.com> > > --- > > .../files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/target/linux/ipq806x/files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts b/target/linux/ipq806x/files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts > > index 580e0f86bb..19fba2d075 100644 > > --- a/target/linux/ipq806x/files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts > > +++ b/target/linux/ipq806x/files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts > > @@ -237,6 +237,7 @@ > > }; > > > > firmware@860000 { > > + compatible = "openwrt,fit-firmware"; > > label = "firmware"; > > reg = <0x860000 0x17a0000>; > > }; > Hi Christian, thanks your work. > However, NEC WG2600HP uses standard uImage firmware in OpenWrt, so it > should to use /compatible = "denx,uimage";/. Thanks for letting me know, I've dropped the patch. > > And, I prepared some fixes and cleanups for this device in my repo[1]. > > By the way, if set compatible string to "firmware" node that is not > under "partitions" (compatible = "fixed-partitions") node, the kernel > could not recognize that node as a partition in WG2600HP. > Since I could not verify the problem sufficiently, I informed it as a > reference. Now that you mention it, I read about this before and I remember where: This behaviour is described in the partition.txt devicetree binding [0]: | For backwards compatibility partitions as direct subnodes of the flash device are | supported. This use is discouraged. | NOTE: also for backwards compatibility, direct subnodes that have a compatible | string are not considered partitions, as they may be used for other bindings. [0] <https://www.kernel.org/doc/Documentation/devicetree/bindings/mtd/partition.txt> So it's because of backwards compatibility that this will never work.
On 2018/12/10 1:44, Christian Lamparter wrote: > | For backwards compatibility partitions as direct subnodes of the flash device are > | supported. This use is discouraged. > | NOTE: also for backwards compatibility, direct subnodes that have a compatible > | string are not considered partitions, as they may be used for other bindings. > > [0]<https://www.kernel.org/doc/Documentation/devicetree/bindings/mtd/partition.txt> > > So it's because of backwards compatibility that this will never work. Oh, I did not know it. Thanks for your information!
diff --git a/target/linux/ipq806x/files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts b/target/linux/ipq806x/files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts index 580e0f86bb..19fba2d075 100644 --- a/target/linux/ipq806x/files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts +++ b/target/linux/ipq806x/files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts @@ -237,6 +237,7 @@ }; firmware@860000 { + compatible = "openwrt,fit-firmware"; label = "firmware"; reg = <0x860000 0x17a0000>; };
Specify firmware partition format by compatible string. Cc: INAGAKI Hiroshi <musashino.open@gmail.com> Signed-off-by: Christian Lamparter <chunkeey@gmail.com> --- .../files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts | 1 + 1 file changed, 1 insertion(+)