| Message ID | 20181208170216.32555-7-georgi.djakov@linaro.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Introduce on-chip interconnect API | expand |
Hi, On Sat, Dec 8, 2018 at 9:02 AM Georgi Djakov <georgi.djakov@linaro.org> wrote: > > From: David Dai <daidavid1@codeaurora.org> > > Add RSC (Resource State Coordinator) provider > dictating network-on-chip interconnect bus performance > found on SDM845-based platforms. > > Signed-off-by: David Dai <daidavid1@codeaurora.org> > Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index b72bdb0a31a5..b3cd256a154e 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -1324,6 +1324,11 @@ > compatible = "qcom,sdm845-rpmh-clk"; > #clock-cells = <1>; > }; > + > + rsc_hlos: interconnect { > + compatible = "qcom,sdm845-rsc-hlos"; > + #interconnect-cells = <1>; > + }; It would have been convenient if this patch had also added an include above: #include <dt-bindings/interconnect/qcom,sdm845.h> ...while the include isn't technically needed by this patch, all the patches that want to actually _use_ the interconnect will need to add the #include and then you get to some fun fights about who has to add the include in which patch. For instance these two patches won't compile: * https://lkml.kernel.org/r/1545373748-1416-1-git-send-email-jshekhar@codeaurora.org * https://lkml.kernel.org/r/20181220173026.3857-4-jcrouse@codeaurora.org ...because neither of them happened to add the include. Maybe they were both assuming someone else would do it? If nobody else wants to, I'm happy to post a patch to add that include myself and it can be applied atop this one. ...or if this patch needs to spin for some other reason maybe you could add it into this patch directly? -Doug
Hi Doug, On 1/10/19 01:18, Doug Anderson wrote: > Hi, > > On Sat, Dec 8, 2018 at 9:02 AM Georgi Djakov <georgi.djakov@linaro.org> wrote: >> >> From: David Dai <daidavid1@codeaurora.org> >> >> Add RSC (Resource State Coordinator) provider >> dictating network-on-chip interconnect bus performance >> found on SDM845-based platforms. >> >> Signed-off-by: David Dai <daidavid1@codeaurora.org> >> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> >> --- >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> index b72bdb0a31a5..b3cd256a154e 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> @@ -1324,6 +1324,11 @@ >> compatible = "qcom,sdm845-rpmh-clk"; >> #clock-cells = <1>; >> }; >> + >> + rsc_hlos: interconnect { >> + compatible = "qcom,sdm845-rsc-hlos"; >> + #interconnect-cells = <1>; >> + }; > > It would have been convenient if this patch had also added an include above: > > #include <dt-bindings/interconnect/qcom,sdm845.h> > > ...while the include isn't technically needed by this patch, all the > patches that want to actually _use_ the interconnect will need to add > the #include and then you get to some fun fights about who has to add > the include in which patch. For instance these two patches won't > compile: > > * https://lkml.kernel.org/r/1545373748-1416-1-git-send-email-jshekhar@codeaurora.org > * https://lkml.kernel.org/r/20181220173026.3857-4-jcrouse@codeaurora.org > > ...because neither of them happened to add the include. Maybe they > were both assuming someone else would do it? > > > If nobody else wants to, I'm happy to post a patch to add that include > myself and it can be applied atop this one. ...or if this patch needs > to spin for some other reason maybe you could add it into this patch > directly? Ok, i will add it and resend. Thanks, Georgi
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index b72bdb0a31a5..b3cd256a154e 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -1324,6 +1324,11 @@ compatible = "qcom,sdm845-rpmh-clk"; #clock-cells = <1>; }; + + rsc_hlos: interconnect { + compatible = "qcom,sdm845-rsc-hlos"; + #interconnect-cells = <1>; + }; }; intc: interrupt-controller@17a00000 {