| Message ID | a3029c0dc2a700edc8f37b8831979c247486838c.1308489767.git.richard.cochran@omicron.at |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index c0a4f3a..3e54337 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -2028,8 +2028,7 @@ static inline void sw_tx_timestamp(struct sk_buff *skb) * skb_tx_timestamp() - Driver hook for transmit timestamping * * Ethernet MAC Drivers should call this function in their hard_xmit() - * function as soon as possible after giving the sk_buff to the MAC - * hardware, but before freeing the sk_buff. + * function immediately before giving the sk_buff to the MAC hardware. * * @skb: A socket buffer. */
The comment for the skb_tx_timestamp() function suggests calling it just after a buffer is released to the hardware for transmission. However, for drivers that free the buffer in an ISR, this produces a race between the time stamp code and the ISR. This commit changes the comment to advise placing the call just before handing the buffer over to the hardware. Signed-off-by: Richard Cochran <richard.cochran@omicron.at> --- include/linux/skbuff.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)