[-next] cifs: remove set but not used variable 'smb_buf'

Message ID 1544166338-55271-1-git-send-email-yuehaibing@huawei.com
State New
Headers show
Series
  • [-next] cifs: remove set but not used variable 'smb_buf'
Related show

Commit Message

YueHaibing Dec. 7, 2018, 7:05 a.m.
Fixes gcc '-Wunused-but-set-variable' warning:

fs/cifs/sess.c: In function '_sess_auth_rawntlmssp_assemble_req':
fs/cifs/sess.c:1157:18: warning:
 variable 'smb_buf' set but not used [-Wunused-but-set-variable]

It never used since commit cc87c47d9d7a ("cifs: Separate rawntlmssp auth
from CIFS_SessSetup()")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 fs/cifs/sess.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Steve French Dec. 7, 2018, 7:27 a.m. | #1
merged into cifs-2.6.git for-next
On Fri, Dec 7, 2018 at 12:57 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/cifs/sess.c: In function '_sess_auth_rawntlmssp_assemble_req':
> fs/cifs/sess.c:1157:18: warning:
>  variable 'smb_buf' set but not used [-Wunused-but-set-variable]
>
> It never used since commit cc87c47d9d7a ("cifs: Separate rawntlmssp auth
> from CIFS_SessSetup()")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  fs/cifs/sess.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
> index 7fa447a..dcd49ad 100644
> --- a/fs/cifs/sess.c
> +++ b/fs/cifs/sess.c
> @@ -1154,14 +1154,12 @@ struct sess_data {
>  static int
>  _sess_auth_rawntlmssp_assemble_req(struct sess_data *sess_data)
>  {
> -       struct smb_hdr *smb_buf;
>         SESSION_SETUP_ANDX *pSMB;
>         struct cifs_ses *ses = sess_data->ses;
>         __u32 capabilities;
>         char *bcc_ptr;
>
>         pSMB = (SESSION_SETUP_ANDX *)sess_data->iov[0].iov_base;
> -       smb_buf = (struct smb_hdr *)pSMB;
>
>         capabilities = cifs_ssetup_hdr(ses, pSMB);
>         if ((pSMB->req.hdr.Flags2 & SMBFLG2_UNICODE) == 0) {
>
>
>

Patch

diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
index 7fa447a..dcd49ad 100644
--- a/fs/cifs/sess.c
+++ b/fs/cifs/sess.c
@@ -1154,14 +1154,12 @@  struct sess_data {
 static int
 _sess_auth_rawntlmssp_assemble_req(struct sess_data *sess_data)
 {
-	struct smb_hdr *smb_buf;
 	SESSION_SETUP_ANDX *pSMB;
 	struct cifs_ses *ses = sess_data->ses;
 	__u32 capabilities;
 	char *bcc_ptr;
 
 	pSMB = (SESSION_SETUP_ANDX *)sess_data->iov[0].iov_base;
-	smb_buf = (struct smb_hdr *)pSMB;
 
 	capabilities = cifs_ssetup_hdr(ses, pSMB);
 	if ((pSMB->req.hdr.Flags2 & SMBFLG2_UNICODE) == 0) {