[U-Boot,1/4] rockchip: rk3399-puma: Cleanup vdd_log node in puma DTSI.

Message ID 20181206112542.20143-2-christoph.muellner@theobroma-systems.com
State Superseded
Delegated to: Philipp Tomsich
Headers show
Series
  • rk3399: puma: Enable PWM regulator for Puma.
Related show

Commit Message

Christoph Muellner Dec. 6, 2018, 11:25 a.m.
* Eliminate non-standard entries (rockchip,pwm_id and
   rockchip,pwm_voltage).
 * Define target voltage level for vdd-log to 950 mV.

Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
---
 arch/arm/dts/rk3399-puma.dtsi | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Philipp Tomsich Dec. 6, 2018, 1:35 p.m. | #1
Christoph,

> On 06.12.2018, at 12:25, Christoph Muellner <christoph.muellner@theobroma-systems.com> wrote:
> 
> * Eliminate non-standard entries (rockchip,pwm_id and
>   rockchip,pwm_voltage).
> * Define target voltage level for vdd-log to 950 mV.

Could  you provide the necessary background in the commit message to
assert that the non-standard entries are indeed not needed and why you
want to set the voltage to 950mV?

In other words: a bit of motivation for this change would be appreciated.

> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
> ---
> arch/arm/dts/rk3399-puma.dtsi | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi
> index 11ffcb71778..2cac16e2ce7 100644
> --- a/arch/arm/dts/rk3399-puma.dtsi
> +++ b/arch/arm/dts/rk3399-puma.dtsi
> @@ -180,10 +180,7 @@
> 		regulator-max-microvolt = <1400000>;
> 		regulator-always-on;
> 		regulator-boot-on;
> -
> -		/* for rockchip boot on */
> -		rockchip,pwm_id= <2>;
> -		rockchip,pwm_voltage = <1000000>;
> +		regulator-init-microvolt = <950000>;
> 	};
> };
> 
> -- 
> 2.11.0
>

Patch

diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi
index 11ffcb71778..2cac16e2ce7 100644
--- a/arch/arm/dts/rk3399-puma.dtsi
+++ b/arch/arm/dts/rk3399-puma.dtsi
@@ -180,10 +180,7 @@ 
 		regulator-max-microvolt = <1400000>;
 		regulator-always-on;
 		regulator-boot-on;
-
-		/* for rockchip boot on */
-		rockchip,pwm_id= <2>;
-		rockchip,pwm_voltage = <1000000>;
+		regulator-init-microvolt = <950000>;
 	};
 };