[NET-NEXT,06/14] e1000e: remove unnecessary header file inclusions

Submitted by Jeff Kirsher on Nov. 21, 2008, 7 p.m.

Details

Message ID 20081121190035.32313.26432.stgit@gitlost.lost
State Rejected
Delegated to: David Miller
Headers show

Commit Message

Jeff Kirsher Nov. 21, 2008, 7 p.m.
From: Bruce Allan <bruce.w.allan@intel.com>

timer.h and workqueue.h do not need to be explicitly included.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---

 drivers/net/e1000e/e1000.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Nov. 22, 2008, 12:53 a.m.
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 21 Nov 2008 11:00:35 -0800

> From: Bruce Allan <bruce.w.allan@intel.com>
> 
> timer.h and workqueue.h do not need to be explicitly included.
> 
> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

You are using "struct timer_list" et al. in this header file so
you do in fact need to include these header files.

If the idea is to rely upon getting these headers indirectly,
that's not how things work.

Not applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch hide | download patch | download mbox

diff --git a/drivers/net/e1000e/e1000.h b/drivers/net/e1000e/e1000.h
index c55fd6f..e09a181 100644
--- a/drivers/net/e1000e/e1000.h
+++ b/drivers/net/e1000e/e1000.h
@@ -32,8 +32,6 @@ 
 #define _E1000_H_
 
 #include <linux/types.h>
-#include <linux/timer.h>
-#include <linux/workqueue.h>
 #include <linux/io.h>
 #include <linux/netdevice.h>