[U-Boot,1/5] serial: Move new functions to serial.h

Message ID 20181205195353.246542-2-sjg@chromium.org
State New
Delegated to: Simon Glass
Headers show
Series
  • dm: serial: Fix up some serial API errors
Related show

Commit Message

Simon Glass Dec. 5, 2018, 7:53 p.m.
We should not be adding new functions to common.h. Move these recently
added functions to serial.h.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 include/common.h | 5 -----
 include/serial.h | 4 ++++
 2 files changed, 4 insertions(+), 5 deletions(-)

Patch

diff --git a/include/common.h b/include/common.h
index 20c99da1aa9..43d348b67c9 100644
--- a/include/common.h
+++ b/include/common.h
@@ -357,8 +357,6 @@  void smp_set_core_boot_addr(unsigned long addr, int corenr);
 void smp_kick_all_cpus(void);
 
 /* $(CPU)/serial.c */
-struct serial_device_info;
-
 int	serial_init   (void);
 void	serial_setbrg (void);
 void	serial_putc   (const char);
@@ -366,9 +364,6 @@  void	serial_putc_raw(const char);
 void	serial_puts   (const char *);
 int	serial_getc   (void);
 int	serial_tstc   (void);
-int	serial_getconfig(uint *config);
-int	serial_setconfig(uint config);
-int	serial_getinfo(struct serial_device_info *info);
 
 /* $(CPU)/speed.c */
 int	get_clocks (void);
diff --git a/include/serial.h b/include/serial.h
index c1a9fee250e..fa7e0130bd2 100644
--- a/include/serial.h
+++ b/include/serial.h
@@ -281,6 +281,10 @@  struct serial_dev_priv {
 /* Access the serial operations for a device */
 #define serial_get_ops(dev)	((struct dm_serial_ops *)(dev)->driver->ops)
 
+int serial_getconfig(uint *config);
+int serial_setconfig(uint config);
+int serial_getinfo(struct serial_device_info *info);
+
 void atmel_serial_initialize(void);
 void mcf_serial_initialize(void);
 void mpc85xx_serial_initialize(void);