From patchwork Wed Dec 5 06:05:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robinson Wu X-Patchwork-Id: 1008008 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=qq.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hACQZXs7"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="k1bhduHd"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=qq.com header.i=@qq.com header.b="ImkDft/4"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 438pD66K8zz9s7W for ; Wed, 5 Dec 2018 17:07:18 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: Date:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=1JNxcv7oUZRuctn5SONslo1zr3QKd4PGEwjAI7sLkwk=; b=hACQZXs71KF9jO 9n7PSTnKUDKgi0ex7edwQCo3VLfaxPlfbeC7Dht29Xf5BpQIKr/NK36ABozowU3ryhyAA27swoP2Q IXcjMJnNfcRBD74kAB9039neB2YmFv1728L/SqYlh/HJc4hom7jLWyHq7WckBJdmIgY1aL70KN2Tb xamU7PxUHPaDxm3uJwVekkJYHisbiYCbCp3Lrs0bkDLfnuDHUrdYhnXeqJ2fjuhRL/C0UCwDUYuAa O8rsI65dWVd4bR/cF7gQHWaVGcWUuDve0VjgxLzUJYcjPDtVZqA4jLxgIebbTynrs0VaQ23ujMj9p O8hgiYLjO8T4ZXFJwWEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUQL5-0005QZ-Cw; Wed, 05 Dec 2018 06:07:15 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUQL3-0005Q5-Rx for openwrt-devel@bombadil.infradead.org; Wed, 05 Dec 2018 06:07:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ze7l18ag4+wHCsPd9cfB/32p+6HNlIq2vgBDaAyZ5mw=; b=k1bhduHdt75eVlBYDPYDhRFxB 6lfH+v/HMzL8YYXYS5DIsUVyi9rbSl9I6anfLSTF/3k24030BdCSai3kx/X9Q75YDKWunDeQ4zFPm dZYnHFqQodtISjoTAiWWMHRX0YqQdDBh9pLowvzgm9gsn/LkPSItPEttBi7sBfnl9QMBxHH0heE1f aH4TFIq9o7LXVeS8mbnSHf4kH453aZQn3ZTj5ifddaj2mOUjXC3bSdjmzgmGQpasbk7TZymb8LMSX JKKcsqRR8HYk1XsQwM/1maPANHb7LzSGsyWmUxjv72cWOc26+jKfvHyQmrV5L8DEpsIH5120f8cpW uxcE7j1cg==; Received: from smtpbgau1.qq.com ([54.206.16.166]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUQKc-0008MP-BW for openwrt-devel@lists.openwrt.org; Wed, 05 Dec 2018 06:06:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1543989956; bh=ze7l18ag4+wHCsPd9cfB/32p+6HNlIq2vgBDaAyZ5mw=; h=From:To:Cc:Subject:Date:Message-Id; b=ImkDft/45tBMYKzsg4KBWyvL/DP6KLqYRkJ7+InqcVl49Bwar6Uc2LAXlM0bqkCVL fQB26iFsse6WOEsoEcGmY5BA9T9wI+me6OlHH720iEH439mtyOMRm2Blw1AD8R70JS ItnsB6pfckb3nMq7AVX6yIJ9ZRs8QeSiLE4CQlz0= X-QQ-mid: esmtp3t1543989954tpb952jke Received: from localhost.localdomain (unknown [125.121.212.63]) by esmtp4.qq.com (ESMTP) with id ; Wed, 05 Dec 2018 14:05:54 +0800 (CST) X-QQ-SSF: B1000000000000F0FH100600000000Z X-QQ-FEAT: 0ESs8nxzjD+Hsnl9qglFxxwfePszS3ciabZVPLhtChjYGhAyU/IXDwxaWylS+ 8xb51IpxeJ5sEnFGLqbw3aZMvN64TkG8JaxNwyoDjGY65+U+bEDxgBvosROSwu0QCWdV4ib Vzqcdz8z0wZl/pkIOw8x9PVEU9UWTZcyJ5Mao+WR+x11qN+4dsCFhcd+nLPffD3NpJ/172i PufoHApDG5V+iNEXwomAKd5OJnUMAMEvL31l5FwtmR5AqfC+9dOVduZnT7FOGbq79+pDUvN g9IuRwk+9mDzT5EjazDsI/ZolfiFW7uJb/H7x3IltKRv9B6TZV0tJ1huA= X-QQ-GoodBg: 0 From: robinson To: openwrt-devel@lists.openwrt.org Date: Wed, 5 Dec 2018 14:05:48 +0800 Message-Id: <1543989948-7268-1-git-send-email-wurobinson@qq.com> X-Mailer: git-send-email 2.7.4 X-QQ-SENDSIZE: 520 Feedback-ID: esmtp:qq.com:bgforeign:bgforeign2 X-QQ-Bgrelay: 1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181205_060651_565785_40DE29F7 X-CRM114-Status: UNSURE ( 7.58 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-0.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [54.206.16.166 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (wurobinson[at]qq.com) -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [OpenWrt-Devel] [PATCH] base-files:fix a bug when add led timer trigger X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robinson MIME-Version: 1.0 Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org When I tried to add a led timer tirgger in "target/linux/ramips/base-files/ etc/board.d/01_leds" like below ucidef_set_led_timer "system" "system" "zhuotk:green:system" "1000" "1000" it will be failed to add value to "delayon" and "delayoff". This commit fix this bug. Signed-off-by: robinson --- package/base-files/files/lib/functions/uci-defaults.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/package/base-files/files/lib/functions/uci-defaults.sh b/package/base-files/files/lib/functions/uci-defaults.sh index 315df7b..23bde9a 100755 --- a/package/base-files/files/lib/functions/uci-defaults.sh +++ b/package/base-files/files/lib/functions/uci-defaults.sh @@ -463,6 +463,7 @@ _ucidef_set_led_timer() { _ucidef_set_led_common "$1" "$2" "$3" + json_add_string type timer json_add_string trigger "$trigger_name" json_add_int delayon "$delayon" json_add_int delayoff "$delayoff"