[v6,09/20] rtc: pic32: Switch to use %ptR

Message ID	20181204212330.69515-10-andriy.shevchenko@linux.intel.com
State	Accepted
Headers	show Return-Path: <linux-rtc-owner@vger.kernel.org> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>, Geert Uytterhoeven <geert@linux-m68k.org>, linux-kernel@vger.kernel.org, Rasmus Villemoes <rasmus.villemoes@prevas.dk>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v6 09/20] rtc: pic32: Switch to use %ptR Date: Tue, 4 Dec 2018 23:23:19 +0200 Message-Id: <20181204212330.69515-10-andriy.shevchenko@linux.intel.com> In-Reply-To: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com> References: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk
Series	lib, rtc: Print rtc_time via %ptR[dt][r] \| expand [v6,00/20] lib, rtc: Print rtc_time via %ptR[dt][r] [v6,01/20] lib/vsprintf: Print time and date in human readable format via %pt [v6,02/20] rtc: Switch to use %ptR [v6,03/20] rtc: at91rm9200: Switch to use %ptR [v6,04/20] rtc: at91sam9: Switch to use %ptR [v6,05/20] rtc: m41t80: Switch to use %ptR [v6,06/20] rtc: m48t59: Switch to use %ptR [v6,07/20] rtc: mcp795: Switch to use %ptR [v6,08/20] rtc: pcf50633: Switch to use %ptR [v6,09/20] rtc: pic32: Switch to use %ptR [v6,10/20] rtc: pm8xxx: Switch to use %ptR [v6,11/20] rtc: puv3: Switch to use %ptR [v6,12/20] rtc: rk808: Switch to use %ptR [v6,13/20] rtc: rx6110: Switch to use %ptR [v6,14/20] rtc: rx8025: Switch to use %ptR [v6,15/20] rtc: s3c: Switch to use %ptR [v6,16/20] rtc: s5m: Switch to use %ptR [v6,17/20] rtc: tegra: Switch to use %ptR [v6,18/20] Input: hp_sdc_rtc - Switch to use %ptR [v6,19/20] m68k/mac: Switch to use %ptR [v6,20/20] PM: Switch to use %ptR

Message ID

20181204212330.69515-10-andriy.shevchenko@linux.intel.com

State

Accepted

Headers

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>, linux-kernel@vger.kernel.org,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v6 09/20] rtc: pic32: Switch to use %ptR
Date: Tue,  4 Dec 2018 23:23:19 +0200
Message-Id: <20181204212330.69515-10-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com>
References: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-rtc-owner@vger.kernel.org
Precedence: bulk

Series

lib, rtc: Print rtc_time via %ptR[dt][r] | expand

Commit Message

Andy Shevchenko Dec. 4, 2018, 9:23 p.m. UTC

Use %ptR instead of open coded variant to print content of
struct rtc_time in human readable format.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/rtc/rtc-pic32.c | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/drivers/rtc/rtc-pic32.c b/drivers/rtc/rtc-pic32.c
index 3c08eab4f1a8..d7ef0a6f8931 100644
--- a/drivers/rtc/rtc-pic32.c
+++ b/drivers/rtc/rtc-pic32.c
@@ -170,9 +170,7 @@  static int pic32_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm)
 
 	rtc_tm->tm_year += 100;
 
-	dev_dbg(dev, "read time %04d.%02d.%02d %02d:%02d:%02d\n",
-		1900 + rtc_tm->tm_year, rtc_tm->tm_mon, rtc_tm->tm_mday,
-		rtc_tm->tm_hour, rtc_tm->tm_min, rtc_tm->tm_sec);
+	dev_dbg(dev, "read time %ptR\n", rtc_tm);
 
 	clk_disable(pdata->clk);
 	return 0;
@@ -184,9 +182,7 @@  static int pic32_rtc_settime(struct device *dev, struct rtc_time *tm)
 	void __iomem *base = pdata->reg_base;
 	int year = tm->tm_year - 100;
 
-	dev_dbg(dev, "set time %04d.%02d.%02d %02d:%02d:%02d\n",
-		1900 + tm->tm_year, tm->tm_mon, tm->tm_mday,
-		tm->tm_hour, tm->tm_min, tm->tm_sec);
+	dev_dbg(dev, "set time %ptR\n", tm);
 
 	if (year < 0 || year >= 100) {
 		dev_err(dev, "rtc only supports 100 years\n");
@@ -224,10 +220,7 @@  static int pic32_rtc_getalarm(struct device *dev, struct rtc_wkalrm *alrm)
 
 	alrm->enabled = (alm_en & PIC32_RTCALRM_ALRMEN) ? 1 : 0;
 
-	dev_dbg(dev, "getalarm: %d, %04d.%02d.%02d %02d:%02d:%02d\n",
-		alm_en,
-		1900 + alm_tm->tm_year, alm_tm->tm_mon, alm_tm->tm_mday,
-		alm_tm->tm_hour, alm_tm->tm_min, alm_tm->tm_sec);
+	dev_dbg(dev, "getalarm: %d, %ptR\n", alm_en, alm_tm);
 
 	alm_tm->tm_sec = bcd2bin(alm_tm->tm_sec);
 	alm_tm->tm_min = bcd2bin(alm_tm->tm_min);
@@ -247,10 +240,7 @@  static int pic32_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
 	void __iomem *base = pdata->reg_base;
 
 	clk_enable(pdata->clk);
-	dev_dbg(dev, "setalarm: %d, %04d.%02d.%02d %02d:%02d:%02d\n",
-		alrm->enabled,
-		1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday,
-		tm->tm_hour, tm->tm_min, tm->tm_sec);
+	dev_dbg(dev, "setalarm: %d, %ptR\n", alrm->enabled, tm);
 
 	writel(0x00, base + PIC32_ALRMTIME);
 	writel(0x00, base + PIC32_ALRMDATE);

[v6,09/20] rtc: pic32: Switch to use %ptR

Commit Message

Patch