[v6,14/20] rtc: rx8025: Switch to use %ptR

Message ID	20181204212330.69515-15-andriy.shevchenko@linux.intel.com
State	Accepted
Headers	show Return-Path: <linux-rtc-owner@vger.kernel.org> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>, Geert Uytterhoeven <geert@linux-m68k.org>, linux-kernel@vger.kernel.org, Rasmus Villemoes <rasmus.villemoes@prevas.dk>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v6 14/20] rtc: rx8025: Switch to use %ptR Date: Tue, 4 Dec 2018 23:23:24 +0200 Message-Id: <20181204212330.69515-15-andriy.shevchenko@linux.intel.com> In-Reply-To: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com> References: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk
Series	lib, rtc: Print rtc_time via %ptR[dt][r] \| expand [v6,00/20] lib, rtc: Print rtc_time via %ptR[dt][r] [v6,01/20] lib/vsprintf: Print time and date in human readable format via %pt [v6,02/20] rtc: Switch to use %ptR [v6,03/20] rtc: at91rm9200: Switch to use %ptR [v6,04/20] rtc: at91sam9: Switch to use %ptR [v6,05/20] rtc: m41t80: Switch to use %ptR [v6,06/20] rtc: m48t59: Switch to use %ptR [v6,07/20] rtc: mcp795: Switch to use %ptR [v6,08/20] rtc: pcf50633: Switch to use %ptR [v6,09/20] rtc: pic32: Switch to use %ptR [v6,10/20] rtc: pm8xxx: Switch to use %ptR [v6,11/20] rtc: puv3: Switch to use %ptR [v6,12/20] rtc: rk808: Switch to use %ptR [v6,13/20] rtc: rx6110: Switch to use %ptR [v6,14/20] rtc: rx8025: Switch to use %ptR [v6,15/20] rtc: s3c: Switch to use %ptR [v6,16/20] rtc: s5m: Switch to use %ptR [v6,17/20] rtc: tegra: Switch to use %ptR [v6,18/20] Input: hp_sdc_rtc - Switch to use %ptR [v6,19/20] m68k/mac: Switch to use %ptR [v6,20/20] PM: Switch to use %ptR

Message ID

20181204212330.69515-15-andriy.shevchenko@linux.intel.com

State

Accepted

Headers

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>, linux-kernel@vger.kernel.org,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v6 14/20] rtc: rx8025: Switch to use %ptR
Date: Tue,  4 Dec 2018 23:23:24 +0200
Message-Id: <20181204212330.69515-15-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com>
References: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-rtc-owner@vger.kernel.org
Precedence: bulk

Series

lib, rtc: Print rtc_time via %ptR[dt][r] | expand

Commit Message

Andy Shevchenko Dec. 4, 2018, 9:23 p.m. UTC

Use %ptR instead of open coded variant to print content of
struct rtc_time in human readable format.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/rtc/rtc-rx8025.c | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)

diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c
index 41127adf5765..41de38acc570 100644
--- a/drivers/rtc/rtc-rx8025.c
+++ b/drivers/rtc/rtc-rx8025.c
@@ -193,10 +193,7 @@  static int rx8025_get_time(struct device *dev, struct rtc_time *dt)
 	if (err)
 		return err;
 
-	dev_dbg(dev, "%s: read 0x%02x 0x%02x "
-		"0x%02x 0x%02x 0x%02x 0x%02x 0x%02x\n", __func__,
-		date[0], date[1], date[2], date[3], date[4],
-		date[5], date[6]);
+	dev_dbg(dev, "%s: read %7ph\n", __func__, date);
 
 	dt->tm_sec = bcd2bin(date[RX8025_REG_SEC] & 0x7f);
 	dt->tm_min = bcd2bin(date[RX8025_REG_MIN] & 0x7f);
@@ -210,9 +207,7 @@  static int rx8025_get_time(struct device *dev, struct rtc_time *dt)
 	dt->tm_mon = bcd2bin(date[RX8025_REG_MONTH] & 0x1f) - 1;
 	dt->tm_year = bcd2bin(date[RX8025_REG_YEAR]) + 100;
 
-	dev_dbg(dev, "%s: date %ds %dm %dh %dmd %dm %dy\n", __func__,
-		dt->tm_sec, dt->tm_min, dt->tm_hour,
-		dt->tm_mday, dt->tm_mon, dt->tm_year);
+	dev_dbg(dev, "%s: date %ptRr\n", __func__, dt);
 
 	return 0;
 }
@@ -243,10 +238,7 @@  static int rx8025_set_time(struct device *dev, struct rtc_time *dt)
 	date[RX8025_REG_MONTH] = bin2bcd(dt->tm_mon + 1);
 	date[RX8025_REG_YEAR] = bin2bcd(dt->tm_year - 100);
 
-	dev_dbg(dev,
-		"%s: write 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x\n",
-		__func__,
-		date[0], date[1], date[2], date[3], date[4], date[5], date[6]);
+	dev_dbg(dev, "%s: write %7ph\n", __func__, date);
 
 	ret = rx8025_write_regs(rx8025->client, RX8025_REG_SEC, 7, date);
 	if (ret < 0)
@@ -319,10 +311,7 @@  static int rx8025_read_alarm(struct device *dev, struct rtc_wkalrm *t)
 		t->time.tm_hour = bcd2bin(ald[1] & 0x1f) % 12
 			+ (ald[1] & 0x20 ? 12 : 0);
 
-	dev_dbg(dev, "%s: date: %ds %dm %dh %dmd %dm %dy\n",
-		__func__,
-		t->time.tm_sec, t->time.tm_min, t->time.tm_hour,
-		t->time.tm_mday, t->time.tm_mon, t->time.tm_year);
+	dev_dbg(dev, "%s: date: %ptRr\n", __func__, t);
 	t->enabled = !!(rx8025->ctrl1 & RX8025_BIT_CTRL1_DALE);
 	t->pending = (ctrl2 & RX8025_BIT_CTRL2_DAFG) && t->enabled;

[v6,14/20] rtc: rx8025: Switch to use %ptR

Commit Message

Patch