| Message ID | 1308298294.13535.3.camel@phoenix |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Fri, Jun 17, 2011 at 1:11 AM, Axel Lin <axel.lin@gmail.com> wrote: > - err = mtd_device_parse_register(&info->mtd, NULL, 0, > + err = mtd_device_parse_register(onenand->mtd, NULL, 0, > pdata ? pdata->parts : NULL, > pdata ? pdata->nr_parts : 0); Wouldn't it be just the same (and shorter) to use "mtd" instead of onenand->mtd? Like: err = mtd_device_parse_register(mtd, NULL, 0, pdata ? pdata->parts : NULL, pdata ? pdata->nr_parts : 0); Brian
On Fri, 2011-06-17 at 10:10 -0700, Brian Norris wrote: > Hi, > > On Fri, Jun 17, 2011 at 1:11 AM, Axel Lin <axel.lin@gmail.com> wrote: > > - err = mtd_device_parse_register(&info->mtd, NULL, 0, > > + err = mtd_device_parse_register(onenand->mtd, NULL, 0, > > pdata ? pdata->parts : NULL, > > pdata ? pdata->nr_parts : 0); Yeah, just did this, thanks.
diff --git a/drivers/mtd/onenand/samsung.c b/drivers/mtd/onenand/samsung.c index 597dffc..d324074 100644 --- a/drivers/mtd/onenand/samsung.c +++ b/drivers/mtd/onenand/samsung.c @@ -1014,7 +1014,7 @@ static int s3c_onenand_probe(struct platform_device *pdev) if (s3c_read_reg(MEM_CFG_OFFSET) & ONENAND_SYS_CFG1_SYNC_READ) dev_info(&onenand->pdev->dev, "OneNAND Sync. Burst Read enabled\n"); - err = mtd_device_parse_register(&info->mtd, NULL, 0, + err = mtd_device_parse_register(onenand->mtd, NULL, 0, pdata ? pdata->parts : NULL, pdata ? pdata->nr_parts : 0);
Fix below build error: CC drivers/mtd/onenand/samsung.o drivers/mtd/onenand/samsung.c: In function 's3c_onenand_probe': drivers/mtd/onenand/samsung.c:1017: error: 'info' undeclared (first use in this function) drivers/mtd/onenand/samsung.c:1017: error: (Each undeclared identifier is reported only once drivers/mtd/onenand/samsung.c:1017: error: for each function it appears in.) make[3]: *** [drivers/mtd/onenand/samsung.o] Error 1 make[2]: *** [drivers/mtd/onenand] Error 2 make[1]: *** [drivers/mtd] Error 2 make: *** [drivers] Error 2 Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/mtd/onenand/samsung.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)