Patchwork Commit 94968e74 breaks f_lotsbad

login
register
mail settings
Submitter Andreas Dilger
Date June 17, 2011, 6:28 a.m.
Message ID <418F4E42-50E6-4CAA-B6F5-CA59B17E84C0@whamcloud.com>
Download mbox | patch
Permalink /patch/100764/
State Superseded
Headers show

Comments

Andreas Dilger - June 17, 2011, 6:28 a.m.
Ted,
I was going to send some more fixes, but it looks like your commit
94968e74 "libext2fs: teach bitmap functions about bigalloc/cluster"
breaks the "f_lotsbad" test, which I found via git bisect and verified
is the offending commit:


I couldn't see the obvious correlation between the failure and the patch,
though it is clear the patch is changing ext2fs_test_generic_bitmap(),
but all of the changes should be no-ops because cluster_bits should be 0
unless bigalloc is enabled.

My tree is up to b2e6c86d6, "mke2fs, e2fsck: fix i_blocks handling for bigalloc file systems", which AFAICS is the latest.

Cheers, Andreas
--
Andreas Dilger 
Principal Engineer
Whamcloud, Inc.



--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - June 20, 2011, 1:58 a.m.
On Fri, Jun 17, 2011 at 12:28:01AM -0600, Andreas Dilger wrote:
> Ted,
> I was going to send some more fixes, but it looks like your commit
> 94968e74 "libext2fs: teach bitmap functions about bigalloc/cluster"
> breaks the "f_lotsbad" test, which I found via git bisect and verified
> is the offending commit:

The problem was a bug in lib/ext2fs/Makefile.in; the $(SRCS) macro
included "$(srcdir)/blkmap64_ba.o" (note ".o" instead of ".o"; Oops.)

As a result we didn't have a dependency for blkmap64_ba.c in the
Makefile, and so blkmap64_ba.o wasn't getting regenerated when
bmap64.h changed.  You can fix it by rm'ing blkmap64_ba.o and then
rebuilding.  I'll fixed the Makefile.in, rerun "make depend", and then
check in a fix.

Regards,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- ./f_lotsbad/expect.1        2011-06-01 20:25:00.871615457 +0000
+++ f_lotsbad.1.log     2011-06-17 05:33:37.398073505 +0000
@@ -26,6 +26,7 @@ 
 
 Restarting e2fsck from the beginning...
 Pass 1: Checking inodes, blocks, and sizes
+Illegal block number passed to ext2fs_test_block_bitmap #0 for in-use block map
 Pass 2: Checking directory structure
 Entry 'termcap' in / (2) has deleted/unused inode 12.  Clear? yes