Patchwork [testsuite] scan-dump variants to use 'unresolved' for missing dump file

login
register
mail settings
Submitter Janis Johnson
Date June 17, 2011, 1:11 a.m.
Message ID <4DFAA9B9.1010100@codesourcery.com>
Download mbox | patch
Permalink /patch/100749/
State New
Headers show

Comments

Janis Johnson - June 17, 2011, 1:11 a.m.
Currently, scan-dump variants treat a missing dump file as a failure and
append ": dump file does not exist" to the test message that would be
used with pass or fail.  This patch treats it as unresolved instead,
using the same test message as for pass/fail and reporting the reason
in the log file.

Tested with dummy tests that use all of these procs for either pass,
fail, or unresolved.  OK for trunk, and later for 4.6?

Janis
2011-06-16  Janis Johnson  <janisjo@codesourcery.com>

	* lib/scandump.exp (scan-dump, scan-dump-times, scan-dump-not,
	scan-dump-dem, scan-dump-dem-not): Treat a missing dump file as
	unresolved and report the reason to the log file.
Mike Stump - June 19, 2011, 9:31 p.m.
On Jun 16, 2011, at 6:11 PM, Janis Johnson wrote:
> Currently, scan-dump variants treat a missing dump file as a failure and
> append ": dump file does not exist" to the test message that would be
> used with pass or fail.  This patch treats it as unresolved instead,
> using the same test message as for pass/fail and reporting the reason
> in the log file.
> 
> Tested with dummy tests that use all of these procs for either pass,
> fail, or unresolved.  OK for trunk, and later for 4.6?

Ok.

Patch

Index: lib/scandump.exp
===================================================================
--- lib/scandump.exp	(revision 175083)
+++ lib/scandump.exp	(working copy)
@@ -55,7 +55,8 @@ 
     set src [file tail [lindex $testcase 0]]
     set output_file "[glob -nocomplain $src.[lindex $args 2]]"
     if { $output_file == "" } {
-	fail "$testname: dump file does not exist"
+	verbose -log "$testcase: dump file does not exist"
+	unresolved "$testname"
 	return
     }
 
@@ -97,7 +98,8 @@ 
     set src [file tail [lindex $testcase 0]]
     set output_file "[glob -nocomplain $src.[lindex $args 3]]"
     if { $output_file == "" } {
-	fail "$testname: dump file does not exist"
+	verbose -log "$testcase: dump file does not exist"
+	unresolved "$testname"
 	return
     }
 
@@ -139,7 +141,8 @@ 
     set src [file tail [lindex $testcase 0]]
     set output_file "[glob -nocomplain $src.[lindex $args 2]]"
     if { $output_file == "" } {
-	fail "$testname: dump file does not exist"
+	verbose -log "$testcase: dump file does not exist"
+	unresolved "$testname"
 	return
     }
 
@@ -190,7 +193,8 @@ 
     set src [file tail [lindex $testcase 0]]
     set output_file "[glob -nocomplain $src.[lindex $args 2]]"
     if { $output_file == "" } {
-	fail "$testname: dump file does not exist"
+	verbose -log "$testcase: dump file does not exist"
+	unresolved "$testname"
 	return
     }
 
@@ -241,7 +245,8 @@ 
     set src [file tail [lindex $testcase 0]]
     set output_file "[glob -nocomplain $src.[lindex $args 2]]"
     if { $output_file == "" } {
-	fail "$testname: dump file does not exist"
+	verbose -log "$testcase: dump file does not exist"
+	unresolved "$testname"
 	return
     }