| Message ID | 20181203100747.16442-3-jagan@amarulasolutions.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | media/sun6i: Allwinner A64 CSI support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Mon, Dec 3, 2018 at 6:08 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > Most of the Allwinner A64 CSI controllers are supply with > VCC-PE pin. which need to supply for some of the boards to > trigger the power. > > So, document the supply property as vcc-csi so-that the required > board can eable it via device tree. > > Used vcc-csi instead of vcc-pe to have better naming convention > wrt other controller pin supplies. This is not related to the CSI controller. It belongs in the pin controller, but that has its own set of problems like possible circular dependencies. ChenYu
On Mon, Dec 03, 2018 at 06:11:35PM +0800, Chen-Yu Tsai wrote: > On Mon, Dec 3, 2018 at 6:08 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > > > Most of the Allwinner A64 CSI controllers are supply with > > VCC-PE pin. which need to supply for some of the boards to > > trigger the power. > > > > So, document the supply property as vcc-csi so-that the required > > board can eable it via device tree. > > > > Used vcc-csi instead of vcc-pe to have better naming convention > > wrt other controller pin supplies. > > This is not related to the CSI controller. It belongs in the pin > controller, but that has its own set of problems like possible > circular dependencies. That might be a better choice, but I think most platforms put the supply in the module node. But that wouldn't work well if the module is not used and you want to use the pins for GPIO or some other function. Maybe we don't hit that property because most I/O supplies are always on. Rob
diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt b/Documentation/devicetree/bindings/media/sun6i-csi.txt index e78cf4f9bc8c..5fb6fd4e2c7d 100644 --- a/Documentation/devicetree/bindings/media/sun6i-csi.txt +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt @@ -18,6 +18,9 @@ Required properties: - clock-names: the clock names mentioned above - resets: phandles to the reset line driving the CSI +Optional properties: + - vcc-csi-supply: the VCC-CSI power supply of the CSI PE group + The CSI node should contain one 'port' child node with one child 'endpoint' node, according to the bindings defined in Documentation/devicetree/bindings/media/video-interfaces.txt.
Most of the Allwinner A64 CSI controllers are supply with VCC-PE pin. which need to supply for some of the boards to trigger the power. So, document the supply property as vcc-csi so-that the required board can eable it via device tree. Used vcc-csi instead of vcc-pe to have better naming convention wrt other controller pin supplies. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Documentation/devicetree/bindings/media/sun6i-csi.txt | 3 +++ 1 file changed, 3 insertions(+)