Message ID | 1308243870-30203-1-git-send-email-Gregory.Dietsche@cuw.edu |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Greg Dietsche <Gregory.Dietsche@cuw.edu> Date: Thu, 16 Jun 2011 12:04:30 -0500 > Compile tested. > remove unnecessary code that matches this coccinelle pattern > if (...) > return ret; > return ret; > > Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/phy/icplus.c b/drivers/net/phy/icplus.c index 9a09e24..d4cbc29 100644 --- a/drivers/net/phy/icplus.c +++ b/drivers/net/phy/icplus.c @@ -109,11 +109,7 @@ static int ip1001_config_init(struct phy_device *phydev) value = phy_read(phydev, 16); value |= 0x3; - err = phy_write(phydev, 16, value); - if (err < 0) - return err; - - return err; + return phy_write(phydev, 16, value); } static int ip175c_read_status(struct phy_device *phydev)
Compile tested. remove unnecessary code that matches this coccinelle pattern if (...) return ret; return ret; Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> --- drivers/net/phy/icplus.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-)