diff mbox series

[v1,12/26] gpio: pch: Remove duplicate assignments

Message ID	20181129145716.62065-13-andriy.shevchenko@linux.intel.com
State	New
Headers	show Return-Path: <linux-gpio-owner@vger.kernel.org> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, linux-gpio@vger.kernel.org Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v1 12/26] gpio: pch: Remove duplicate assignments Date: Thu, 29 Nov 2018 16:57:02 +0200 Message-Id: <20181129145716.62065-13-andriy.shevchenko@linux.intel.com> In-Reply-To: <20181129145716.62065-1-andriy.shevchenko@linux.intel.com> References: <20181129145716.62065-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk
Series	gpio: Clean up Intel GPIO drivers \| expand [v1,00/26] gpio: Clean up Intel GPIO drivers [v1,01/26] gpio: pch: Convert to use managed functions pcim_* and devm_* [v1,02/26] gpio: sodaville: Convert to use managed functions pcim_* and devm_* [v1,03/26] gpio: pch: Convert to dev_pm_ops [v1,04/26] gpio: lynxpoint: Use for_each_set_bit() in IRQ handler [v1,05/26] gpio: pch: Use for_each_set_bit() in IRQ handler [v1,06/26] gpio: sodaville: Use for_each_set_bit() in IRQ handler [v1,07/26] gpio: ich: Simplify error handling in ichx_write_bit() [v1,08/26] gpio: ich: Switch to use struct device instead of platform_device [v1,09/26] gpio: ich: Convert pr_<level> to dev_<level> [v1,10/26] gpio: ich: Join string literals back [v1,11/26] gpio: pch: Remove redundant __func__ from debug print [v1,12/26] gpio: pch: Remove duplicate assignments [v1,13/26] gpio: intel-mid: Remove linux/module.h and sort headers [v1,14/26] gpio: lynxpoint: Remove linux/init.h and sort headers [v1,15/26] gpio: merrifield: Remove linux/init.h [v1,16/26] gpio: sch: Remove linux/init.h and sort headers [v1,17/26] gpio: ich: Sort headers alphabetically [v1,18/26] gpio: pch: Sort headers alphabetically [v1,19/26] gpio: sodaville: Sort headers alphabetically [v1,20/26] gpio: ich: Convert to use SPDX identifier [v1,21/26] gpio: intel-mid: Convert to use SPDX identifier [v1,22/26] gpio: lynxpoint: Convert to use SPDX identifier [v1,23/26] gpio: merrifield: Convert to use SPDX identifier [v1,24/26] gpio: pch: Convert to use SPDX identifier [v1,25/26] gpio: sch: Convert to use SPDX identifier [v1,26/26] gpio: sodaville: Convert to use SPDX identifier

Commit Message

Andy Shevchenko Nov. 29, 2018, 2:57 p.m. UTC

There is no need to assign the same values which core does for us anyway.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-pch.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff mbox series

Patch

diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index ba5199c681df..1134a21ad156 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -224,7 +224,6 @@  static void pch_gpio_setup(struct pch_gpio *chip)
 	gpio->get = pch_gpio_get;
 	gpio->direction_output = pch_gpio_direction_output;
 	gpio->set = pch_gpio_set;
-	gpio->dbg_show = NULL;
 	gpio->base = -1;
 	gpio->ngpio = gpio_pins[chip->ioh];
 	gpio->can_sleep = false;
@@ -391,9 +390,7 @@  static int pch_gpio_probe(struct pci_dev *pdev,
 	pci_set_drvdata(pdev, chip);
 	spin_lock_init(&chip->spinlock);
 	pch_gpio_setup(chip);
-#ifdef CONFIG_OF_GPIO
-	chip->gpio.of_node = pdev->dev.of_node;
-#endif
+
 	ret = devm_gpiochip_add_data(&pdev->dev, &chip->gpio, chip);
 	if (ret) {
 		dev_err(&pdev->dev, "PCH gpio: Failed to register GPIO\n");