Patchwork [v2] Add support for RTC device: pt7c4338 in rtc-ds1307.c

login
register
mail settings
Submitter Priyanka Jain
Date June 15, 2011, 8:59 a.m.
Message ID <1308128390-23347-1-git-send-email-Priyanka.Jain@freescale.com>
Download mbox | patch
Permalink /patch/100498/
State New
Headers show

Comments

Priyanka Jain - June 15, 2011, 8:59 a.m.
PT7C4338 chip is being manufactured by Pericom Technology Inc.
It is a serial real-time clock which provides:
1)Low-power clock/calendar.
2)Programmable square-wave output.
It has 56 bytes of nonvolatile RAM.
Its register set is same as that of rtc device: DS1307.


Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
---
 Change for v2:
	 Incorporting Andrew Morton's comments to shorten patch by using
         hunk: { "pt7c4338", ds_1307 }

 Changes :
	 This patch will supersede patch:
		"RTC driver(Linux) for PT7C4338 chip"
	 Incorporting Wolfram Sang's comments to reuse ds1307 driver.

 drivers/rtc/Kconfig      |    6 +++---
 drivers/rtc/rtc-ds1307.c |    3 +++
 2 files changed, 6 insertions(+), 3 deletions(-)
Tabi Timur-B04825 - June 15, 2011, 11:44 a.m.
Priyanka Jain wrote:
> + *  Copyright (C) 2011 Priyanka Jain (Priyanka.Jain@freescale.com)
> + *                                   (pt7c4338 support)

You can't claim copyright just by adding one line of text.
Timur Tabi - June 15, 2011, 3:05 p.m.
Priyanka Jain wrote:
>  config RTC_DRV_DS1307
> -	tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025"
> +	tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025, PT7C4338"
>  	help
>  	  If you say yes here you get support for various compatible RTC
>  	  chips (often with battery backup) connected with I2C. This driver
>  	  should handle DS1307, DS1337, DS1338, DS1339, DS1340, ST M41T00,
> -	  EPSON RX-8025 and probably other chips. In some cases the RTC
> -	  must already have been initialized (by manufacturing or a
> +	  EPSON RX-8025, PT7C4338 and probably other chips. In some cases 
> +	  the RTC  must already have been initialized (by manufacturing or a
>  	  bootloader).

I think you should probably drop the Kconfig change, too.  It already says, "and
probably other chips", and you're also just bloating the summary line.  We can't
list every possible Dallas-compatible RTC chip here.

Patch

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index b8f4e9e..c6045dd 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -126,13 +126,13 @@  comment "I2C RTC drivers"
 if I2C
 
 config RTC_DRV_DS1307
-	tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025"
+	tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025, PT7C4338"
 	help
 	  If you say yes here you get support for various compatible RTC
 	  chips (often with battery backup) connected with I2C. This driver
 	  should handle DS1307, DS1337, DS1338, DS1339, DS1340, ST M41T00,
-	  EPSON RX-8025 and probably other chips. In some cases the RTC
-	  must already have been initialized (by manufacturing or a
+	  EPSON RX-8025, PT7C4338 and probably other chips. In some cases 
+	  the RTC  must already have been initialized (by manufacturing or a
 	  bootloader).
 
 	  The first seven registers on these chips hold an RTC, and other
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 4724ba3..e851394 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -4,6 +4,8 @@ 
  *  Copyright (C) 2005 James Chapman (ds1337 core)
  *  Copyright (C) 2006 David Brownell
  *  Copyright (C) 2009 Matthias Fuchs (rx8025 support)
+ *  Copyright (C) 2011 Priyanka Jain (Priyanka.Jain@freescale.com)
+ *                                   (pt7c4338 support)
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
@@ -149,6 +151,7 @@  static const struct i2c_device_id ds1307_id[] = {
 	{ "ds1340", ds_1340 },
 	{ "ds3231", ds_3231 },
 	{ "m41t00", m41t00 },
+	{ "pt7c4338", ds_1307 },
 	{ "rx8025", rx_8025 },
 	{ }
 };