Patchwork ext4: fix incorrect error msg in ext4_ext_insert_index

login
register
mail settings
Submitter Robin Dong
Date June 15, 2011, 2:25 a.m.
Message ID <1308104726-5112-1-git-send-email-sanbai@taobao.com>
Download mbox | patch
Permalink /patch/100469/
State Accepted
Headers show

Comments

Robin Dong - June 15, 2011, 2:25 a.m.
In function ext4_ext_insert_index when eh_entries of curp is
bigger than eh_max, error messages will be printed out, but the content
is about logical and ei_block, that's incorret.

Signed-off-by: Robin Dong <sanbai@taobao.com>
---
 fs/ext4/extents.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Theodore Ts'o - June 27, 2011, 7:36 p.m.
On Wed, Jun 15, 2011 at 10:25:26AM +0800, Robin Dong wrote:
> In function ext4_ext_insert_index when eh_entries of curp is
> bigger than eh_max, error messages will be printed out, but the content
> is about logical and ei_block, that's incorret.
> 
> Signed-off-by: Robin Dong <sanbai@taobao.com>

Added to the ext4 tree, thanks!!

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 5199bac..25be6e0 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -808,8 +808,9 @@  static int ext4_ext_insert_index(handle_t *handle, struct inode *inode,
 	if (unlikely(le16_to_cpu(curp->p_hdr->eh_entries)
 			     > le16_to_cpu(curp->p_hdr->eh_max))) {
 		EXT4_ERROR_INODE(inode,
-				 "logical %d == ei_block %d!",
-				 logical, le32_to_cpu(curp->p_idx->ei_block));
+				 "eh_entries %d > eh_max %d!",
+				 le16_to_cpu(curp->p_hdr->eh_entries),
+				 le16_to_cpu(curp->p_hdr->eh_max));
 		return -EIO;
 	}
 	if (unlikely(ix > EXT_LAST_INDEX(curp->p_hdr))) {