| Message ID | 20181128093013.24442-4-wens@csie.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | rtc: sun6i: clock rework and pre-H6 SoC support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, Nov 28, 2018 at 05:30:00PM +0800, Chen-Yu Tsai wrote: > The A31 does not have an external clock output directly from the RTC. > Instead, it has four muxable clock outputs: three (A, B, C) are > controlled from the CCU, and the last (D) is controlled from the PRCM. > > Deprecate the usage of the external clock output for the A31 compatible. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> I guess we should add a warning in the code as well if one tries to use it. Maxime
On Wed, Nov 28, 2018 at 6:20 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Wed, Nov 28, 2018 at 05:30:00PM +0800, Chen-Yu Tsai wrote: > > The A31 does not have an external clock output directly from the RTC. > > Instead, it has four muxable clock outputs: three (A, B, C) are > > controlled from the CCU, and the last (D) is controlled from the PRCM. > > > > Deprecate the usage of the external clock output for the A31 compatible. > > > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> > > I guess we should add a warning in the code as well if one tries to > use it. That's on the TODO list. :)
diff --git a/Documentation/devicetree/bindings/rtc/sun6i-rtc.txt b/Documentation/devicetree/bindings/rtc/sun6i-rtc.txt index b1eaa443347d..78c4fb472eb7 100644 --- a/Documentation/devicetree/bindings/rtc/sun6i-rtc.txt +++ b/Documentation/devicetree/bindings/rtc/sun6i-rtc.txt @@ -30,6 +30,8 @@ Required properties for new device trees The RTC provides the following clocks at the given indices: - 0: LOSC - 1: LOSC external output, known as X32KFOUT in the datasheet. + This clock is not available on the A31 and is deprecated for old + device trees still using the "allwinner,sun6i-a31-rtc" compatible. Example: @@ -37,7 +39,7 @@ rtc: rtc@1f00000 { compatible = "allwinner,sun6i-a31-rtc"; reg = <0x01f00000 0x54>; interrupts = <0 40 4>, <0 41 4>; - clock-output-names = "osc32k", "osc32k-out"; + clock-output-names = "osc32k"; clocks = <&ext_osc32k>; #clock-cells = <1>; };
The A31 does not have an external clock output directly from the RTC. Instead, it has four muxable clock outputs: three (A, B, C) are controlled from the CCU, and the last (D) is controlled from the PRCM. Deprecate the usage of the external clock output for the A31 compatible. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- Documentation/devicetree/bindings/rtc/sun6i-rtc.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)