ARM: debug-imx: only define DEBUG_IMX_UART_PORT if needed

Message ID 20181128090416.14695-1-u.kleine-koenig@pengutronix.de
State New
Headers show
Series
  • ARM: debug-imx: only define DEBUG_IMX_UART_PORT if needed
Related show

Commit Message

Uwe Kleine-König Nov. 28, 2018, 9:04 a.m.
If debugging on i.MX is enabled DEBUG_IMX_UART_PORT defines which UART
is used for the debug output. If however debugging is off don't only
hide the then unused config item but drop it completely by using a
dependency instead of a conditional prompt.

This fixes DEBUG_IMX_UART_PORT being present in the kernel config even
if DEBUG_LL is disabled.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm/Kconfig.debug | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

Comments

Shawn Guo Dec. 5, 2018, 1:20 a.m. | #1
On Wed, Nov 28, 2018 at 10:04:16AM +0100, Uwe Kleine-König wrote:
> If debugging on i.MX is enabled DEBUG_IMX_UART_PORT defines which UART
> is used for the debug output. If however debugging is off don't only
> hide the then unused config item but drop it completely by using a
> dependency instead of a conditional prompt.
> 
> This fixes DEBUG_IMX_UART_PORT being present in the kernel config even
> if DEBUG_LL is disabled.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Applied, thanks.

Patch

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index d6a49f59ecd9..3f057593db01 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1440,21 +1440,21 @@  config DEBUG_OMAP2PLUS_UART
 	depends on ARCH_OMAP2PLUS
 
 config DEBUG_IMX_UART_PORT
-	int "i.MX Debug UART Port Selection" if DEBUG_IMX1_UART || \
-						DEBUG_IMX25_UART || \
-						DEBUG_IMX21_IMX27_UART || \
-						DEBUG_IMX31_UART || \
-						DEBUG_IMX35_UART || \
-						DEBUG_IMX50_UART || \
-						DEBUG_IMX51_UART || \
-						DEBUG_IMX53_UART || \
-						DEBUG_IMX6Q_UART || \
-						DEBUG_IMX6SL_UART || \
-						DEBUG_IMX6SX_UART || \
-						DEBUG_IMX6UL_UART || \
-						DEBUG_IMX7D_UART
+	int "i.MX Debug UART Port Selection"
+	depends on DEBUG_IMX1_UART ||
+		   DEBUG_IMX25_UART ||
+		   DEBUG_IMX21_IMX27_UART ||
+		   DEBUG_IMX31_UART ||
+		   DEBUG_IMX35_UART ||
+		   DEBUG_IMX50_UART ||
+		   DEBUG_IMX51_UART ||
+		   DEBUG_IMX53_UART ||
+		   DEBUG_IMX6Q_UART ||
+		   DEBUG_IMX6SL_UART ||
+		   DEBUG_IMX6SX_UART ||
+		   DEBUG_IMX6UL_UART ||
+		   DEBUG_IMX7D_UART
 	default 1
-	depends on ARCH_MXC
 	help
 	  Choose UART port on which kernel low-level debug messages
 	  should be output.