diff mbox series

dt-bindings: clock: Require #reset-cells in sdm845-videocc

Message ID 20181127192443.136158-1-dianders@chromium.org
State Not Applicable, archived
Headers show
Series dt-bindings: clock: Require #reset-cells in sdm845-videocc | expand

Checks

Context Check Description
robh/checkpatch warning "total: 0 errors, 1 warnings, 13 lines checked"

Commit Message

Doug Anderson Nov. 27, 2018, 7:24 p.m. UTC 
The #reset-cells was listed as optional in the bindings for
qcom,sdm845-videocc.  There's no reason for it to be optional.  As per
Stephen [1]:

> We should update the binding to make it a required property. It
> doesn't make any sense why that property would be optional given
> that the hardware either has support for resets or it doesn't.

sdm845 support is still in its infancy so we shouldn't be affecting
any real device trees by modifying the bindings here.

[1] https://lkml.kernel.org/r/154330186815.88331.12720647562079303842@swboyd.mtv.corp.google.com

Fixes: 84b66b211603 ("dt-bindings: clock: Introduce QCOM Video clock bindings")
Suggested-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 Documentation/devicetree/bindings/clock/qcom,videocc.txt | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Stephen Boyd Nov. 30, 2018, 9:01 a.m. UTC | #1 
Quoting Douglas Anderson (2018-11-27 11:24:43)
> The #reset-cells was listed as optional in the bindings for
> qcom,sdm845-videocc.  There's no reason for it to be optional.  As per
> Stephen [1]:
> 
> > We should update the binding to make it a required property. It
> > doesn't make any sense why that property would be optional given
> > that the hardware either has support for resets or it doesn't.
> 
> sdm845 support is still in its infancy so we shouldn't be affecting
> any real device trees by modifying the bindings here.
> 
> [1] https://lkml.kernel.org/r/154330186815.88331.12720647562079303842@swboyd.mtv.corp.google.com
> 
> Fixes: 84b66b211603 ("dt-bindings: clock: Introduce QCOM Video clock bindings")
> Suggested-by: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.txt b/Documentation/devicetree/bindings/clock/qcom,videocc.txt
index e7c035afa778..8a8622c65c5a 100644
--- a/Documentation/devicetree/bindings/clock/qcom,videocc.txt
+++ b/Documentation/devicetree/bindings/clock/qcom,videocc.txt
@@ -6,8 +6,6 @@  Required properties :
 - reg : shall contain base register location and length
 - #clock-cells : from common clock binding, shall contain 1.
 - #power-domain-cells : from generic power domain binding, shall contain 1.
-
-Optional properties :
 - #reset-cells : from common reset binding, shall contain 1.
 
 Example:
@@ -16,4 +14,5 @@  Example:
 		reg = <0xab00000 0x10000>;
 		#clock-cells = <1>;
 		#power-domain-cells = <1>;
+		#reset-cells = <1>;
 	};