[dev-4.18] ARM: dts: aspeed: Fix gpio interrupt controller description

Message ID 378621543319425@iva8-f16495710718.qloud-c.yandex.net
State Rejected, archived
Headers show
Series
  • [dev-4.18] ARM: dts: aspeed: Fix gpio interrupt controller description
Related show

Commit Message

Konstantin Klubnichkin Nov. 27, 2018, 11:50 a.m.
Missing #interrupt-cells in gpio controller DTS  description causes OF subsystem to ignore it 
as an interrupt controller, so one can't use gpio external interrupts. This patch fixes it.

Signed-off-by: Konstantin Klubnichkin <kitsok@yandex-team.ru>
---
 arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
 arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
 2 files changed, 2 insertions(+)

--
1.9.1




-- 
Best regards,
Konstantin Klubnichkin,
lead firmware engineer,
server hardware R&D group,
Yandex Moscow office.
tel: +7-903-510-33-33

Comments

Joel Stanley Jan. 17, 2019, 3:43 a.m. | #1
Hi Konstantin,

On Tue, 27 Nov 2018 at 23:05, Konstantin Klubnichkin
<kitsok@yandex-team.ru> wrote:
>
> Missing #interrupt-cells in gpio controller DTS  description causes OF subsystem to ignore it
> as an interrupt controller, so one can't use gpio external interrupts. This patch fixes it.
>
> Signed-off-by: Konstantin Klubnichkin <kitsok@yandex-team.ru>

Apologies for missing your patch. Someone else sent a similar one that
I applied today, so this should be fixed both upstream and in the
dev-4.19 openbmc tree.

Cheers,

Joel

Patch

diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
index 2846173..55732bd 100644
--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi
@@ -195,6 +195,7 @@ 
                                gpio-controller;
                                compatible = "aspeed,ast2400-gpio";
                                reg = <0x1e780000 0x1000>;
+                               #interrupt-cells = <2>;
                                interrupts = <20>;
                                gpio-ranges = <&pinctrl 0 0 220>;
                                clocks = <&syscon ASPEED_CLK_APB>;
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index e4c5de3..d9eafec 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -261,6 +261,7 @@ 
                                gpio-controller;
                                compatible = "aspeed,ast2500-gpio";
                                reg = <0x1e780000 0x1000>;
+                               #interrupt-cells = <2>;
                                interrupts = <20>;
                                gpio-ranges = <&pinctrl 0 0 220>;
                                clocks = <&syscon ASPEED_CLK_APB>;