diff mbox series

[1/6] Add a header file defining Intel Lantiq OUI and vendor extensions

Message ID 20181126093241.25888-1-sarada.prasanna.garnayak@intel.com
State Changes Requested
Headers show
Series [1/6] Add a header file defining Intel Lantiq OUI and vendor extensions | expand

Commit Message

Sarada Prasanna Garnayak Nov. 26, 2018, 9:32 a.m. UTC 
This file is used as a registry of identifier assignments from the
Intel Lantiq OUI 00:13:74 for purposes other than MAC address assignment.
This file adds support for the Intel Lantiq WLAN module configuration
and management using nl80211 vendor commands/events.

Signed-off-by: Sarada Prasanna Garnayak <sarada.prasanna.garnayak@intel.com>
---
 src/common/intel-ltq-vendor.h | 71 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 71 insertions(+)
 create mode 100644 src/common/intel-ltq-vendor.h

Comments

Jouni Malinen Nov. 26, 2018, 11:23 a.m. UTC | #1 
On Mon, Nov 26, 2018 at 03:02:41PM +0530, Sarada Prasanna Garnayak wrote:
> This file is used as a registry of identifier assignments from the
> Intel Lantiq OUI 00:13:74 for purposes other than MAC address assignment.
> This file adds support for the Intel Lantiq WLAN module configuration
> and management using nl80211 vendor commands/events.

00:13:74 is not an Intel Lantiq OUI.. The commit message should be fixed
to talk about the correct OUI.

> diff --git a/src/common/intel-ltq-vendor.h b/src/common/intel-ltq-vendor.h
> @@ -0,0 +1,71 @@
> +/*
> + * Intel Lantiq OUI and vendor specific assignments.
> + * Copyright (c) 2018 The Linux Foundation. All rights reserved.
> + *
> + * Permission to use, copy, modify, and/or distribute this software for any
> + * purpose with or without fee is hereby granted, provided that the above
> + * copyright notice and this permission notice appear in all copies.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
> + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
> + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
> + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
> + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
> + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
> + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
> + *
> + * This software may be distributed under the terms of the BSD license.
> + * See README for more details.
> + */

Could you please clarify what exactly this combination of licensing
terms is supposed to mean? This looks like the ISC License followed by a
claim that the BSD license may be used for distribution. Are you
implying that either license can be used? Would you be fine with
following the same style as most of the files in hostap.git are using
(i.e., just those last two lines)? Or at least least something that is
clearly identifying a single license to use if it is compatible with the
BSD license terms?
diff mbox series

Patch

diff --git a/src/common/intel-ltq-vendor.h b/src/common/intel-ltq-vendor.h
new file mode 100644
index 000000000..6e9febe97
--- /dev/null
+++ b/src/common/intel-ltq-vendor.h
@@ -0,0 +1,71 @@ 
+/*
+ * Intel Lantiq OUI and vendor specific assignments.
+ * Copyright (c) 2018 The Linux Foundation. All rights reserved.
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ *
+ * This software may be distributed under the terms of the BSD license.
+ * See README for more details.
+ */
+
+#ifndef INTEL_LTQ_VENDOR_H
+#define INTEL_LTQ_VENDOR_H
+
+/**
+ * This file is a registry of identifier assignments from
+ * the Intel Lantiq OUI AC:9A:96 for purposes other than MAC address
+ * assignment.
+ * New identifiers can be assigned through normal review process
+ * for changes to the upstream hostap.git repository.
+ */
+
+#define OUI_INTEL_LTQ 0xAC9A96
+
+/*
+ * enum intel_ltq_nl80211_vendor_subcmds - Intel LTQ nl80211
+ * vendor command identifiers.
+ *
+ * @INTEL_LTQ_NL80211_VENDOR_SUBCMD_UNSPEC: Reserved value 0
+ *
+ * @INTEL_LTQ_NL80211_VENDOR_SUBCMD_GET_AID: Send request to
+ * 	the kernel driver to get an association ID for a station
+ * 	during the association phase.
+ *
+ * @INTEL_LTQ_NL80211_VENDOR_SUBCMD_FREE_AID: Send request to
+ * 	the kernel driver to free the association ID of a station
+ * 	during the dissociation phase.
+ *
+ * @INTEL_LTQ_NL80211_VENDOR_SUBCMD_TX_EAPOL: The Intel Lantiq WLAN
+ * 	module support eapol functionality in the driver, this vendor
+ * 	cmd used to offload the eapol tx status work from hostapd
+ * 	to the driver.
+ */
+enum intel_ltq_nl80211_vendor_subcmds {
+	INTEL_LTQ_NL80211_VENDOR_SUBCMD_UNSPEC = 0,
+	INTEL_LTQ_NL80211_VENDOR_SUBCMD_GET_AID = 1,
+	INTEL_LTQ_NL80211_VENDOR_SUBCMD_FREE_AID = 2,
+	INTEL_LTQ_NL80211_VENDOR_SUBCMD_TX_EAPOL = 3,
+};
+
+/*
+ * enum intel_ltq_nl80211_vendor_events - Intel LTQ nl80211
+ * vendor event identifiers.
+ *
+ * @INTEL_LTQ_NL80211_VENDOR_EVENT_RX_EAPOL: Receive EAPOL
+ * 	event.
+ */
+enum intel_ltq_nl80211_vendor_events {
+	INTEL_LTQ_NL80211_VENDOR_EVENT_RX_EAPOL = 0,
+};
+
+#endif /* INTEL_LTQ_VENDOR_H */