[v2,1/3] ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
diff mbox series

Message ID 20181125212159.11590-1-otavio@ossystems.com.br
State New
Headers show
Series
  • [v2,1/3] ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
Related show

Commit Message

Otavio Salvador Nov. 25, 2018, 9:21 p.m. UTC
CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
selected by the Kconfig logic.  This is done in preparation to making
further changes to this defconfig cleaner.

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

Changes in v2:
- rework commit log (Fabio Estevam)

 arch/arm/configs/imx_v6_v7_defconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Otavio Salvador Nov. 25, 2018, 9:45 p.m. UTC | #1
On Sun, Nov 25, 2018 at 7:35 PM Arnd Bergmann <arnd@arndb.de> wrote:
> On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador
> <otavio@ossystems.com.br> wrote:
> >
> > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
> > selected by the Kconfig logic.  This is done in preparation to making
> > further changes to this defconfig cleaner.
> >
>
> Does this mean we no longer get the unwinder, or there is some other
> config (which?) that unconditionally selects it?

It is selected. Before changing the defconfig I did a savedefconfig to
avoid unrelated changes to be included on the subsequent patches and
then I found it was now selected.
Arnd Bergmann Nov. 25, 2018, 9:47 p.m. UTC | #2
On Sun, Nov 25, 2018 at 10:45 PM Otavio Salvador
<otavio.salvador@ossystems.com.br> wrote:
>
> On Sun, Nov 25, 2018 at 7:35 PM Arnd Bergmann <arnd@arndb.de> wrote:
> > On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador
> > <otavio@ossystems.com.br> wrote:
> > >
> > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
> > > selected by the Kconfig logic.  This is done in preparation to making
> > > further changes to this defconfig cleaner.
> > >
> >
> > Does this mean we no longer get the unwinder, or there is some other
> > config (which?) that unconditionally selects it?
>
> It is selected. Before changing the defconfig I did a savedefconfig to
> avoid unrelated changes to be included on the subsequent patches and
> then I found it was now selected.

Ok, then please mention in the changelog which other option selects it,
as I said.

Aside from that, your series looks fine to me.

      Arnd
Otavio Salvador Nov. 25, 2018, 10:21 p.m. UTC | #3
Hello Arnd,

On Sun, Nov 25, 2018 at 7:48 PM Arnd Bergmann <arnd@arndb.de> wrote:
> On Sun, Nov 25, 2018 at 10:45 PM Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
> >
> > On Sun, Nov 25, 2018 at 7:35 PM Arnd Bergmann <arnd@arndb.de> wrote:
> > > On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador
> > > <otavio@ossystems.com.br> wrote:
> > > >
> > > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
> > > > selected by the Kconfig logic.  This is done in preparation to making
> > > > further changes to this defconfig cleaner.
> > > >
> > >
> > > Does this mean we no longer get the unwinder, or there is some other
> > > config (which?) that unconditionally selects it?
> >
> > It is selected. Before changing the defconfig I did a savedefconfig to
> > avoid unrelated changes to be included on the subsequent patches and
> > then I found it was now selected.
>
> Ok, then please mention in the changelog which other option selects it,
> as I said.
>
> Aside from that, your series looks fine to me.

Thank you for reviewing it. I sent a v3 mentioning it.

Patch
diff mbox series

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index aa02d18f44d1..0c887a059df3 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -445,4 +445,3 @@  CONFIG_MAGIC_SYSRQ=y
 CONFIG_PROVE_LOCKING=y
 # CONFIG_DEBUG_BUGVERBOSE is not set
 # CONFIG_FTRACE is not set
-# CONFIG_ARM_UNWIND is not set