[v3] Update mount.cifs with vers=default mount option and SMBv3.0.2

Message ID 20181124134707.15993-1-kdsouza@redhat.com
State New
Headers show
Series
  • [v3] Update mount.cifs with vers=default mount option and SMBv3.0.2
Related show

Commit Message

Kenneth D'souza Nov. 24, 2018, 1:47 p.m.
Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
---
 mount.cifs.rst | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Aurelien Aptel Nov. 26, 2018, 10:50 a.m. | #1
Kenneth D'souza <kdsouza@redhat.com> writes:
> Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
> ---
>  mount.cifs.rst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/mount.cifs.rst b/mount.cifs.rst
> index 405c459..e073261 100644
> --- a/mount.cifs.rst
> +++ b/mount.cifs.rst
> @@ -542,7 +542,12 @@ vers=arg
>      different dialect (2.000) that is not supported.
>    - 2.1 - The SMBv2.1 protocol that was introduced in Microsoft Windows 7 and Windows Server 2008R2.
>    - 3.0 - The SMBv3.0 protocol that was introduced in Microsoft Windows 8 and Windows Server 2012.
> +  - 3.0.2 or 3.02 - The SMBv3.0.2 protocol that was introduced in Windows 8.1(Windows 'Blue') and Windows Server 2012 R2.
>    - 3.1.1 or 3.11 - The SMBv3.1.1 protocol that was introduced in Microsoft Windows Server 2016.
> +  - default - Tries to negotiate the highest SMB2+ version supported by the server.
> +
> +  If no dialect is specified on mount vers=default is used.
> +  To check ``Dialect`` refer to /proc/fs/cifs/DebugData
>  
>    Note too that while this option governs the protocol version used, not
>    all features of each version are available.
> -- 
> 2.17.2
>
>

Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Tom Talpey Nov. 26, 2018, 3:27 p.m. | #2
> -----Original Message-----
> From: linux-cifs-owner@vger.kernel.org <linux-cifs-owner@vger.kernel.org> On
> Behalf Of Aurélien Aptel
> Sent: Monday, November 26, 2018 5:50 AM
> To: Kenneth D'souza <kdsouza@redhat.com>; linux-cifs@vger.kernel.org
> Cc: piastryyy@gmail.com; smfrench@gmail.com
> Subject: Re: [PATCH v3] Update mount.cifs with vers=default mount option and
> SMBv3.0.2
> 
> Kenneth D'souza <kdsouza@redhat.com> writes:
> > Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
> > ---
> >  mount.cifs.rst | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/mount.cifs.rst b/mount.cifs.rst
> > index 405c459..e073261 100644
> > --- a/mount.cifs.rst
> > +++ b/mount.cifs.rst
> > @@ -542,7 +542,12 @@ vers=arg
> >      different dialect (2.000) that is not supported.
> >    - 2.1 - The SMBv2.1 protocol that was introduced in Microsoft Windows 7
> and Windows Server 2008R2.
> >    - 3.0 - The SMBv3.0 protocol that was introduced in Microsoft Windows 8
> and Windows Server 2012.
> > +  - 3.0.2 or 3.02 - The SMBv3.0.2 protocol that was introduced in Windows
> 8.1(Windows 'Blue') and Windows Server 2012 R2.
> >    - 3.1.1 or 3.11 - The SMBv3.1.1 protocol that was introduced in Microsoft
> Windows Server 2016.

Dialect 3.1.1 was also supported starting with Windows 10. This was added in
an earlier patch, did it get lost?

Tom.

> > +  - default - Tries to negotiate the highest SMB2+ version supported by the
> server.
> > +
> > +  If no dialect is specified on mount vers=default is used.
> > +  To check ``Dialect`` refer to /proc/fs/cifs/DebugData
> >
> >    Note too that while this option governs the protocol version used, not
> >    all features of each version are available.
> > --
> > 2.17.2
> >
> >
> 
> Reviewed-by: Aurelien Aptel <aaptel@suse.com>
> 
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
> Nürnberg)
Kenneth D'souza Nov. 26, 2018, 6:03 p.m. | #3
Hello Tom,
It was not added in the earlier patch.
Sorry I missed to add it in V3.
Pavel can you fix it while committing ?

On Mon, Nov 26, 2018 at 11:01 PM Kenneth Dsouza <kdsouza@redhat.com> wrote:
>
> Hello Tom,
> It was not added in the earlier patch.
> Sorry I missed to add it in V3.
> Pavel can you fix it while committing ?
>
> On Mon, Nov 26, 2018 at 8:57 PM Tom Talpey <ttalpey@microsoft.com> wrote:
>>
>> > -----Original Message-----
>> > From: linux-cifs-owner@vger.kernel.org <linux-cifs-owner@vger.kernel.org> On
>> > Behalf Of Aurélien Aptel
>> > Sent: Monday, November 26, 2018 5:50 AM
>> > To: Kenneth D'souza <kdsouza@redhat.com>; linux-cifs@vger.kernel.org
>> > Cc: piastryyy@gmail.com; smfrench@gmail.com
>> > Subject: Re: [PATCH v3] Update mount.cifs with vers=default mount option and
>> > SMBv3.0.2
>> >
>> > Kenneth D'souza <kdsouza@redhat.com> writes:
>> > > Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
>> > > ---
>> > >  mount.cifs.rst | 5 +++++
>> > >  1 file changed, 5 insertions(+)
>> > >
>> > > diff --git a/mount.cifs.rst b/mount.cifs.rst
>> > > index 405c459..e073261 100644
>> > > --- a/mount.cifs.rst
>> > > +++ b/mount.cifs.rst
>> > > @@ -542,7 +542,12 @@ vers=arg
>> > >      different dialect (2.000) that is not supported.
>> > >    - 2.1 - The SMBv2.1 protocol that was introduced in Microsoft Windows 7
>> > and Windows Server 2008R2.
>> > >    - 3.0 - The SMBv3.0 protocol that was introduced in Microsoft Windows 8
>> > and Windows Server 2012.
>> > > +  - 3.0.2 or 3.02 - The SMBv3.0.2 protocol that was introduced in Windows
>> > 8.1(Windows 'Blue') and Windows Server 2012 R2.
>> > >    - 3.1.1 or 3.11 - The SMBv3.1.1 protocol that was introduced in Microsoft
>> > Windows Server 2016.
>>
>> Dialect 3.1.1 was also supported starting with Windows 10. This was added in
>> an earlier patch, did it get lost?
>>
>> Tom.
>>
>> > > +  - default - Tries to negotiate the highest SMB2+ version supported by the
>> > server.
>> > > +
>> > > +  If no dialect is specified on mount vers=default is used.
>> > > +  To check ``Dialect`` refer to /proc/fs/cifs/DebugData
>> > >
>> > >    Note too that while this option governs the protocol version used, not
>> > >    all features of each version are available.
>> > > --
>> > > 2.17.2
>> > >
>> > >
>> >
>> > Reviewed-by: Aurelien Aptel <aaptel@suse.com>
>> >
>> > --
>> > Aurélien Aptel / SUSE Labs Samba Team
>> > GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
>> > SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
>> > GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
>> > Nürnberg)
Pavel Shilovsky Nov. 26, 2018, 9:14 p.m. | #4
Yes, will do. Thanks.

--
Best regards,
Pavel Shilovsky

пн, 26 нояб. 2018 г. в 09:31, Kenneth Dsouza <kdsouza@redhat.com>:
>
> Hello Tom,
> It was not added in the earlier patch.
> Sorry I missed to add it in V3.
> Pavel can you fix it while committing ?
>
> On Mon, Nov 26, 2018 at 8:57 PM Tom Talpey <ttalpey@microsoft.com> wrote:
>>
>> > -----Original Message-----
>> > From: linux-cifs-owner@vger.kernel.org <linux-cifs-owner@vger.kernel.org> On
>> > Behalf Of Aurélien Aptel
>> > Sent: Monday, November 26, 2018 5:50 AM
>> > To: Kenneth D'souza <kdsouza@redhat.com>; linux-cifs@vger.kernel.org
>> > Cc: piastryyy@gmail.com; smfrench@gmail.com
>> > Subject: Re: [PATCH v3] Update mount.cifs with vers=default mount option and
>> > SMBv3.0.2
>> >
>> > Kenneth D'souza <kdsouza@redhat.com> writes:
>> > > Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
>> > > ---
>> > >  mount.cifs.rst | 5 +++++
>> > >  1 file changed, 5 insertions(+)
>> > >
>> > > diff --git a/mount.cifs.rst b/mount.cifs.rst
>> > > index 405c459..e073261 100644
>> > > --- a/mount.cifs.rst
>> > > +++ b/mount.cifs.rst
>> > > @@ -542,7 +542,12 @@ vers=arg
>> > >      different dialect (2.000) that is not supported.
>> > >    - 2.1 - The SMBv2.1 protocol that was introduced in Microsoft Windows 7
>> > and Windows Server 2008R2.
>> > >    - 3.0 - The SMBv3.0 protocol that was introduced in Microsoft Windows 8
>> > and Windows Server 2012.
>> > > +  - 3.0.2 or 3.02 - The SMBv3.0.2 protocol that was introduced in Windows
>> > 8.1(Windows 'Blue') and Windows Server 2012 R2.
>> > >    - 3.1.1 or 3.11 - The SMBv3.1.1 protocol that was introduced in Microsoft
>> > Windows Server 2016.
>>
>> Dialect 3.1.1 was also supported starting with Windows 10. This was added in
>> an earlier patch, did it get lost?
>>
>> Tom.
>>
>> > > +  - default - Tries to negotiate the highest SMB2+ version supported by the
>> > server.
>> > > +
>> > > +  If no dialect is specified on mount vers=default is used.
>> > > +  To check ``Dialect`` refer to /proc/fs/cifs/DebugData
>> > >
>> > >    Note too that while this option governs the protocol version used, not
>> > >    all features of each version are available.
>> > > --
>> > > 2.17.2
>> > >
>> > >
>> >
>> > Reviewed-by: Aurelien Aptel <aaptel@suse.com>
>> >
>> > --
>> > Aurélien Aptel / SUSE Labs Samba Team
>> > GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
>> > SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
>> > GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
>> > Nürnberg)
L. A. Walsh Nov. 26, 2018, 10:49 p.m. | #5
On 11/24/2018 5:47 AM, Kenneth D'souza wrote:
> +  - default - Tries to negotiate the highest SMB2+ version supported by the server.
> +
> +  If no dialect is specified on mount vers=default is used.
>   
---
Should that say "the highest SMB2+ version supported by both the client and
the server"?
L. A. Walsh Nov. 29, 2018, 6:59 p.m. | #6
On 11/24/2018 5:47 AM, Kenneth D'souza wrote:
> +  - default - Tries to negotiate the highest SMB2+ version supported by the server.
> +
> +  If no dialect is specified on mount vers=default is used.
>   
---
Should that say "the highest SMB2+ version supported by both the client and
the server"?
Kenneth D'souza Nov. 30, 2018, 3:32 p.m. | #7
On Fri, Nov 30, 2018 at 12:29 AM L. A. Walsh <linux-cifs@tlinx.org> wrote:
>
> On 11/24/2018 5:47 AM, Kenneth D'souza wrote:
> > +  - default - Tries to negotiate the highest SMB2+ version supported by the server.
> > +
> > +  If no dialect is specified on mount vers=default is used.
> >
> ---
> Should that say "the highest SMB2+ version supported by both the client and
> the server"?
>
Apologies for the delayed response.
Yes, will send a V4.
Kenneth D'souza Nov. 30, 2018, 3:39 p.m. | #8
Pavel should I send a V4?

On Fri, Nov 30, 2018 at 9:02 PM Kenneth Dsouza <kdsouza@redhat.com> wrote:
>
> On Fri, Nov 30, 2018 at 12:29 AM L. A. Walsh <linux-cifs@tlinx.org> wrote:
> >
> > On 11/24/2018 5:47 AM, Kenneth D'souza wrote:
> > > +  - default - Tries to negotiate the highest SMB2+ version supported by the server.
> > > +
> > > +  If no dialect is specified on mount vers=default is used.
> > >
> > ---
> > Should that say "the highest SMB2+ version supported by both the client and
> > the server"?
> >
> Apologies for the delayed response.
> Yes, will send a V4.
Pavel Shilovsky Nov. 30, 2018, 7:29 p.m. | #9
There is a mix of proposed changes in this thread. So, yes, please do.

--
Best regards,
Pavel Shilovsky

пт, 30 нояб. 2018 г. в 07:39, Kenneth Dsouza <kdsouza@redhat.com>:
>
> Pavel should I send a V4?
>
> On Fri, Nov 30, 2018 at 9:02 PM Kenneth Dsouza <kdsouza@redhat.com> wrote:
> >
> > On Fri, Nov 30, 2018 at 12:29 AM L. A. Walsh <linux-cifs@tlinx.org> wrote:
> > >
> > > On 11/24/2018 5:47 AM, Kenneth D'souza wrote:
> > > > +  - default - Tries to negotiate the highest SMB2+ version supported by the server.
> > > > +
> > > > +  If no dialect is specified on mount vers=default is used.
> > > >
> > > ---
> > > Should that say "the highest SMB2+ version supported by both the client and
> > > the server"?
> > >
> > Apologies for the delayed response.
> > Yes, will send a V4.
Pavel Shilovsky Feb. 15, 2019, 1:05 a.m. | #10
пт, 30 нояб. 2018 г. в 11:29, Pavel Shilovsky <piastryyy@gmail.com>:
>
> There is a mix of proposed changes in this thread. So, yes, please do.
>
> --
> Best regards,
> Pavel Shilovsky
>
> пт, 30 нояб. 2018 г. в 07:39, Kenneth Dsouza <kdsouza@redhat.com>:
> >
> > Pavel should I send a V4?
> >
> > On Fri, Nov 30, 2018 at 9:02 PM Kenneth Dsouza <kdsouza@redhat.com> wrote:
> > >
> > > On Fri, Nov 30, 2018 at 12:29 AM L. A. Walsh <linux-cifs@tlinx.org> wrote:
> > > >
> > > > On 11/24/2018 5:47 AM, Kenneth D'souza wrote:
> > > > > +  - default - Tries to negotiate the highest SMB2+ version supported by the server.
> > > > > +
> > > > > +  If no dialect is specified on mount vers=default is used.
> > > > >
> > > > ---
> > > > Should that say "the highest SMB2+ version supported by both the client and
> > > > the server"?
> > > >
> > > Apologies for the delayed response.
> > > Yes, will send a V4.

Hi Kenneth,

Are you still going to submit V4 of your patch? If yes, please rebase
on top of "next" branch before sending
(https://github.com/piastry/cifs-utils/commits/next).

--
Best regards,
Pavel Shilovsky
Kenneth D'souza Feb. 15, 2019, 1:06 a.m. | #11
Yes, will send shortly.

On Fri, Feb 15, 2019 at 6:35 AM Pavel Shilovsky <piastryyy@gmail.com> wrote:
>
> пт, 30 нояб. 2018 г. в 11:29, Pavel Shilovsky <piastryyy@gmail.com>:
> >
> > There is a mix of proposed changes in this thread. So, yes, please do.
> >
> > --
> > Best regards,
> > Pavel Shilovsky
> >
> > пт, 30 нояб. 2018 г. в 07:39, Kenneth Dsouza <kdsouza@redhat.com>:
> > >
> > > Pavel should I send a V4?
> > >
> > > On Fri, Nov 30, 2018 at 9:02 PM Kenneth Dsouza <kdsouza@redhat.com> wrote:
> > > >
> > > > On Fri, Nov 30, 2018 at 12:29 AM L. A. Walsh <linux-cifs@tlinx.org> wrote:
> > > > >
> > > > > On 11/24/2018 5:47 AM, Kenneth D'souza wrote:
> > > > > > +  - default - Tries to negotiate the highest SMB2+ version supported by the server.
> > > > > > +
> > > > > > +  If no dialect is specified on mount vers=default is used.
> > > > > >
> > > > > ---
> > > > > Should that say "the highest SMB2+ version supported by both the client and
> > > > > the server"?
> > > > >
> > > > Apologies for the delayed response.
> > > > Yes, will send a V4.
>
> Hi Kenneth,
>
> Are you still going to submit V4 of your patch? If yes, please rebase
> on top of "next" branch before sending
> (https://github.com/piastry/cifs-utils/commits/next).
>
> --
> Best regards,
> Pavel Shilovsky

Patch

diff --git a/mount.cifs.rst b/mount.cifs.rst
index 405c459..e073261 100644
--- a/mount.cifs.rst
+++ b/mount.cifs.rst
@@ -542,7 +542,12 @@  vers=arg
     different dialect (2.000) that is not supported.
   - 2.1 - The SMBv2.1 protocol that was introduced in Microsoft Windows 7 and Windows Server 2008R2.
   - 3.0 - The SMBv3.0 protocol that was introduced in Microsoft Windows 8 and Windows Server 2012.
+  - 3.0.2 or 3.02 - The SMBv3.0.2 protocol that was introduced in Windows 8.1(Windows 'Blue') and Windows Server 2012 R2.
   - 3.1.1 or 3.11 - The SMBv3.1.1 protocol that was introduced in Microsoft Windows Server 2016.
+  - default - Tries to negotiate the highest SMB2+ version supported by the server.
+
+  If no dialect is specified on mount vers=default is used.
+  To check ``Dialect`` refer to /proc/fs/cifs/DebugData
 
   Note too that while this option governs the protocol version used, not
   all features of each version are available.