| Submitter | Neil Horman |
|---|---|
| Date | June 13, 2011, 3:48 p.m. |
| Message ID | <1307980110-9585-1-git-send-email-nhorman@tuxdriver.com> |
| Download | mbox | patch |
| Permalink | /patch/100168/ |
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
Comments
Good find. LGTM. Signed-off-by: Bhavesh Davda <bhavesh@vmware.com> - Bhavesh Bhavesh P. Davda > -----Original Message----- > From: pv-drivers-bounces@vmware.com [mailto:pv-drivers-bounces@vmware.com] On > Behalf Of Neil Horman > Sent: Monday, June 13, 2011 8:49 AM > To: netdev@vger.kernel.org > Cc: VMware, Inc.; David S. Miller; Neil Horman > Subject: [Pv-drivers] [PATCH] vmxnet3: remove unused variable > > While doing some backporting I noticed that vmxnet3 had a variable that was > set > but never used. Get rid of it, and stop the compiler from griping > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com> > CC: "VMware, Inc." <pv-drivers@vmware.com> > CC: "David S. Miller" <davem@davemloft.net> > --- > drivers/net/vmxnet3/vmxnet3_drv.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c > b/drivers/net/vmxnet3/vmxnet3_drv.c > index fa6e2ac..a9b60a2 100644 > --- a/drivers/net/vmxnet3/vmxnet3_drv.c > +++ b/drivers/net/vmxnet3/vmxnet3_drv.c > @@ -405,10 +405,8 @@ vmxnet3_tq_cleanup(struct vmxnet3_tx_queue *tq, > > while (tq->tx_ring.next2comp != tq->tx_ring.next2fill) { > struct vmxnet3_tx_buf_info *tbi; > - union Vmxnet3_GenericDesc *gdesc; > > tbi = tq->buf_info + tq->tx_ring.next2comp; > - gdesc = tq->tx_ring.base + tq->tx_ring.next2comp; > > vmxnet3_unmap_tx_buf(tbi, adapter->pdev); > if (tbi->skb) { > -- > 1.7.5.4 > > _______________________________________________ > Pv-drivers mailing list > Pv-drivers@vmware.com > http://mailman2.vmware.com/mailman/listinfo/pv-drivers -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index fa6e2ac..a9b60a2 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -405,10 +405,8 @@ vmxnet3_tq_cleanup(struct vmxnet3_tx_queue *tq, while (tq->tx_ring.next2comp != tq->tx_ring.next2fill) { struct vmxnet3_tx_buf_info *tbi; - union Vmxnet3_GenericDesc *gdesc; tbi = tq->buf_info + tq->tx_ring.next2comp; - gdesc = tq->tx_ring.base + tq->tx_ring.next2comp; vmxnet3_unmap_tx_buf(tbi, adapter->pdev); if (tbi->skb) {
While doing some backporting I noticed that vmxnet3 had a variable that was set but never used. Get rid of it, and stop the compiler from griping Signed-off-by: Neil Horman <nhorman@tuxdriver.com> CC: "VMware, Inc." <pv-drivers@vmware.com> CC: "David S. Miller" <davem@davemloft.net> --- drivers/net/vmxnet3/vmxnet3_drv.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)