| Message ID | 20181122090653.3523-4-skolluku@codeaurora.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Use interconnect API in MDSS on SDM845 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Thu, 22 Nov 2018 14:36:53 +0530, Sravanthi Kollukuduru wrote: > Add interconnect properties such as interconnect provider specifier > , the edge source and destination ports which are required by the > interconnect API to configure interconnect path for MDSS. > > Changes in v2: > - none > > Changes in v3: > - Remove common property definitions (Rob Herring) > > Signed-off-by: Sravanthi Kollukuduru <skolluku@codeaurora.org> > --- > Documentation/devicetree/bindings/display/msm/dpu.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Sravanthi, Thanks for the patch! On 11/22/18 11:06, Sravanthi Kollukuduru wrote: > Add interconnect properties such as interconnect provider specifier > , the edge source and destination ports which are required by the > interconnect API to configure interconnect path for MDSS. > > Changes in v2: > - none > > Changes in v3: > - Remove common property definitions (Rob Herring) > > Signed-off-by: Sravanthi Kollukuduru <skolluku@codeaurora.org> > --- > Documentation/devicetree/bindings/display/msm/dpu.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dpu.txt b/Documentation/devicetree/bindings/display/msm/dpu.txt > index ad2e8830324e..d75b4360a4be 100644 > --- a/Documentation/devicetree/bindings/display/msm/dpu.txt > +++ b/Documentation/devicetree/bindings/display/msm/dpu.txt > @@ -28,6 +28,11 @@ Required properties: > - #address-cells: number of address cells for the MDSS children. Should be 1. > - #size-cells: Should be 1. > - ranges: parent bus address space is the same as the child bus address space. > +- interconnects : interconnect path specifier for MDSS according to > + Documentation/devicetree/bindings/interconnect/interconnect.txt. Should be > + 2 paths corresponding to 2 AXI ports. > +- interconnect-names : MDSS will have 2 port names to differentiate between the > + 2 interconnect paths defined with interconnect specifier. > > Optional properties: > - assigned-clocks: list of clock specifiers for clocks needing rate assignment > @@ -86,6 +91,10 @@ Example: > interrupt-controller; > #interrupt-cells = <1>; > > + interconnects = <&qnoc 38 &qnoc 512>, > + <&qnoc 39 &qnoc 512>; Please use string names instead of hard-coded integers. interconnects = <&rsc_hlos MASTER_MDP0 &rsc_hlos SLAVE_EBI1>, <&rsc_hlos MASTER_MDP1 &rsc_hlos SLAVE_EBI1>; > + interconnect-names = "port0", "port1"; We are trying to be more descriptive and include both the source and the destination like: "mdp0-mem", "mdp1-mem" > + > iommus = <&apps_iommu 0>; > > #address-cells = <2>; Otherwise looks good. Thanks, Georgi
diff --git a/Documentation/devicetree/bindings/display/msm/dpu.txt b/Documentation/devicetree/bindings/display/msm/dpu.txt index ad2e8830324e..d75b4360a4be 100644 --- a/Documentation/devicetree/bindings/display/msm/dpu.txt +++ b/Documentation/devicetree/bindings/display/msm/dpu.txt @@ -28,6 +28,11 @@ Required properties: - #address-cells: number of address cells for the MDSS children. Should be 1. - #size-cells: Should be 1. - ranges: parent bus address space is the same as the child bus address space. +- interconnects : interconnect path specifier for MDSS according to + Documentation/devicetree/bindings/interconnect/interconnect.txt. Should be + 2 paths corresponding to 2 AXI ports. +- interconnect-names : MDSS will have 2 port names to differentiate between the + 2 interconnect paths defined with interconnect specifier. Optional properties: - assigned-clocks: list of clock specifiers for clocks needing rate assignment @@ -86,6 +91,10 @@ Example: interrupt-controller; #interrupt-cells = <1>; + interconnects = <&qnoc 38 &qnoc 512>, + <&qnoc 39 &qnoc 512>; + interconnect-names = "port0", "port1"; + iommus = <&apps_iommu 0>; #address-cells = <2>;
Add interconnect properties such as interconnect provider specifier , the edge source and destination ports which are required by the interconnect API to configure interconnect path for MDSS. Changes in v2: - none Changes in v3: - Remove common property definitions (Rob Herring) Signed-off-by: Sravanthi Kollukuduru <skolluku@codeaurora.org> --- Documentation/devicetree/bindings/display/msm/dpu.txt | 9 +++++++++ 1 file changed, 9 insertions(+)