| Message ID | w3p62oa6t8a.wl%kuninori.morimoto.gx@renesas.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Kuninori Morimoto <morimoto.kuninori@renesas.com> Date: Mon, 13 Jun 2011 17:17:09 +0900 > This patch tidyup below warrning > > ${LINUX}/drivers/net/sh_eth.c:1773: warning: > 'mdp' may be used uninitialized in this function > > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> Please just move the mdp assignment right after alloc_netdev() succeeds. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c index 8a72a97..96a629f 100644 --- a/drivers/net/sh_eth.c +++ b/drivers/net/sh_eth.c @@ -1770,7 +1770,7 @@ static int sh_eth_drv_probe(struct platform_device *pdev) int ret, devno = 0; struct resource *res; struct net_device *ndev = NULL; - struct sh_eth_private *mdp; + struct sh_eth_private *mdp = NULL; struct sh_eth_plat_data *pd; /* get base addr */ @@ -1888,7 +1888,7 @@ out_unregister: out_release: /* net_dev free */ - if (mdp->tsu_addr) + if (mdp && mdp->tsu_addr) iounmap(mdp->tsu_addr); if (ndev) free_netdev(ndev);
This patch tidyup below warrning ${LINUX}/drivers/net/sh_eth.c:1773: warning: 'mdp' may be used uninitialized in this function Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com> --- drivers/net/sh_eth.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)