Patchwork [5/6] ARM: mxc: all three imx51 TOs use TO1 version of sdma script

login
register
mail settings
Submitter Shawn Guo
Date June 13, 2011, 7:37 a.m.
Message ID <1307950645-26529-6-git-send-email-shawn.guo@linaro.org>
Download mbox | patch
Permalink /patch/100140/
State New
Headers show

Comments

Shawn Guo - June 13, 2011, 7:37 a.m.
Though there are three TOs of imx51 soc, the sdma script never
changes since TO1, which means all three TOs of imx51 uses TO1
version of sdma script.

The current code passes TO number to imx-sdma driver to load
Fabio Estevam - June 13, 2011, 12:36 p.m.
Hi Shawn,

On Mon, Jun 13, 2011 at 4:37 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> Though there are three TOs of imx51 soc, the sdma script never
> changes since TO1, which means all three TOs of imx51 uses TO1
> version of sdma script.
>
> The current code passes TO number to imx-sdma driver to load
> different firmware for different TO.  That means we have to prepare
> 3 identical firmwares, sdma-imx25-to1.bin sdma-imx25-to2.bin and
> sdma-imx25-to3.bin,

I think you want to mean:
sdma-imx51-to1.bin, sdma-imx51-to2.bin, sdma-imx51-to3.bin

Please fix the commit log.

Regards,

Fabio Estevam
Shawn Guo - June 13, 2011, 1:05 p.m.
On Mon, Jun 13, 2011 at 09:36:45AM -0300, Fabio Estevam wrote:
> Hi Shawn,
> 
> On Mon, Jun 13, 2011 at 4:37 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> > Though there are three TOs of imx51 soc, the sdma script never
> > changes since TO1, which means all three TOs of imx51 uses TO1
> > version of sdma script.
> >
> > The current code passes TO number to imx-sdma driver to load
> > different firmware for different TO.  That means we have to prepare
> > 3 identical firmwares, sdma-imx25-to1.bin sdma-imx25-to2.bin and
> > sdma-imx25-to3.bin,
> 
> I think you want to mean:
> sdma-imx51-to1.bin, sdma-imx51-to2.bin, sdma-imx51-to3.bin
> 
Oops, right.

> Please fix the commit log.
> 
OK.

Patch

different firmware for different TO.  That means we have to prepare
3 identical firmwares, sdma-imx25-to1.bin sdma-imx25-to2.bin and
sdma-imx25-to3.bin, to have the kernel capable of running on all
three TOs.  This just makes no sense.

The patch removes the TO number passing and get the default TO1
version of sdma firmware work for all TOs.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 arch/arm/plat-mxc/devices/platform-imx-dma.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-mxc/devices/platform-imx-dma.c b/arch/arm/plat-mxc/devices/platform-imx-dma.c
index c64f015..2091540 100644
--- a/arch/arm/plat-mxc/devices/platform-imx-dma.c
+++ b/arch/arm/plat-mxc/devices/platform-imx-dma.c
@@ -196,8 +196,6 @@  static int __init imxXX_add_imx_dma(void)
 
 #if defined(CONFIG_SOC_IMX51)
 	if (cpu_is_mx51()) {
-		int to_version = mx51_revision() >> 4;
-		imx51_imx_sdma_data.pdata.to_version = to_version;
 		imx51_imx_sdma_data.pdata.script_addrs = &addr_imx51;
 		ret = imx_add_imx_sdma(&imx51_imx_sdma_data);
 	} else