| Message ID | 4DF4BBBC.8010203@mail.ru |
|---|---|
| State | New |
| Headers | show |
On 06/12/2011 06:14 AM, ferux wrote: > Patch to correct log output about sections from: > start end size prot > 00010000-00019000 00009000 r-x > 00019000-0007b000 00062000 rw- > 00040000-00041000 00001000 --- > 00041000-00041800 00000800 rw- > 00041800-0005d800 0001c000 r-x > 0005d800-0005e800 00001000 rw- > > to: > start end size prot > 10000000-10019000 00019000 r-x > 10019000-1006b000 00052000 rw- > 40000000-40001000 00001000 --- > 40001000-40801000 00800000 rw- > 40801000-4081d000 0001c000 r-x > 4081d000-4081e000 00001000 rw- > > I described this bug: https://bugs.launchpad.net/qemu/+bug/754635. > > Signed-off-by: Max Rozhkov <address@hidden> Acked-by: Richard Henderson <rth@twiddle.net> r~
Hi, Am 12.06.2011 um 15:14 schrieb ferux: > Patch to correct log output about sections from: > start end size prot > 00010000-00019000 00009000 r-x > 00019000-0007b000 00062000 rw- > 00040000-00041000 00001000 --- > 00041000-00041800 00000800 rw- > 00041800-0005d800 0001c000 r-x > 0005d800-0005e800 00001000 rw- > > to: > start end size prot > 10000000-10019000 00019000 r-x > 10019000-1006b000 00052000 rw- > 40000000-40001000 00001000 --- > 40001000-40801000 00800000 rw- > 40801000-4081d000 0001c000 r-x > 4081d000-4081e000 00001000 rw- > > I described this bug: https://bugs.launchpad.net/qemu/+bug/754635. The subject and description need to be improved. The subject might be something like: Fix -d option output about sections with description: Correct log output about sections from: [...] to: [...] [What was wrong / why is that correct?] This resolves bug: ... I.e. make it self-descriptive and tell us for offline-reading what the patch does and why. > Signed-off-by: Max Rozhkov <address@hidden> Please provide a proper address under which the author can be contacted in case of problems or questions. > --- qemu-0.14.1/exec.c.orig 2011-06-12 16:14:51.362434004 +0400 > +++ qemu-0.14.1/exec.c 2011-06-12 16:15:10.652434003 +0400 > @@ -2340,7 +2340,7 @@ int walk_memory_regions(void *priv, walk > data.prot = 0; > > for (i = 0; i < V_L1_SIZE; i++) { > - int rc = walk_memory_regions_1(&data, (abi_ulong)i << > V_L1_SHIFT, > + int rc = walk_memory_regions_1(&data, (abi_ulong)i << > (V_L1_SHIFT + TARGET_PAGE_BITS), Line length > 80 chars. Andreas > V_L1_SHIFT / L2_BITS - 1, > l1_map + i); > if (rc != 0) { > return rc;
--- qemu-0.14.1/exec.c.orig 2011-06-12 16:14:51.362434004 +0400 +++ qemu-0.14.1/exec.c 2011-06-12 16:15:10.652434003 +0400 @@ -2340,7 +2340,7 @@ int walk_memory_regions(void *priv, walk data.prot = 0; for (i = 0; i < V_L1_SIZE; i++) { - int rc = walk_memory_regions_1(&data, (abi_ulong)i << V_L1_SHIFT, + int rc = walk_memory_regions_1(&data, (abi_ulong)i << (V_L1_SHIFT + TARGET_PAGE_BITS), V_L1_SHIFT / L2_BITS - 1, l1_map + i);
Patch to correct log output about sections from: start end size prot 00010000-00019000 00009000 r-x 00019000-0007b000 00062000 rw- 00040000-00041000 00001000 --- 00041000-00041800 00000800 rw- 00041800-0005d800 0001c000 r-x 0005d800-0005e800 00001000 rw- to: start end size prot 10000000-10019000 00019000 r-x 10019000-1006b000 00052000 rw- 40000000-40001000 00001000 --- 40001000-40801000 00800000 rw- 40801000-4081d000 0001c000 r-x 4081d000-4081e000 00001000 rw- I described this bug: https://bugs.launchpad.net/qemu/+bug/754635. Signed-off-by: Max Rozhkov <address@hidden> --- if (rc != 0) { return rc;