arc: [devboards] Add support of NFSv3 ACL

Message ID 20181120103019.12852-1-abrodkin@synopsys.com
State New
Headers show
Series
  • arc: [devboards] Add support of NFSv3 ACL
Related show

Commit Message

Alexey Brodkin Nov. 20, 2018, 10:30 a.m.
By default NFSv3 doesn't support ACL (Access Control Lists)
which might be quite convenient to have so that
mounted NFS behaves exactly as any other local file-system.

In particular missing support of ACL makes umask useless.
This among other thigs fixes Glibc's "nptl/tst-umask1".

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Cupertino Miranda <cmiranda@synopsys.com>
Cc: stable@vger.kernel.org
---
 arch/arc/configs/axs101_defconfig          | 1 +
 arch/arc/configs/axs103_defconfig          | 1 +
 arch/arc/configs/axs103_smp_defconfig      | 1 +
 arch/arc/configs/hsdk_defconfig            | 1 +
 arch/arc/configs/nps_defconfig             | 1 +
 arch/arc/configs/nsimosci_defconfig        | 1 +
 arch/arc/configs/nsimosci_hs_defconfig     | 1 +
 arch/arc/configs/nsimosci_hs_smp_defconfig | 1 +
 arch/arc/configs/vdk_hs38_defconfig        | 1 +
 arch/arc/configs/vdk_hs38_smp_defconfig    | 1 +
 10 files changed, 10 insertions(+)

Comments

Sasha Levin Nov. 21, 2018, 3:24 p.m. | #1
Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v4.19.2, v4.18.19, v4.14.81, v4.9.137, v4.4.163, v3.18.125.

v4.19.2: Build OK!
v4.18.19: Build OK!
v4.14.81: Build OK!
v4.9.137: Failed to apply! Possible dependencies:
    Unable to calculate

v4.4.163: Failed to apply! Possible dependencies:
    Unable to calculate

v3.18.125: Failed to apply! Possible dependencies:
    556cc1c5f528 ("ARC: [axs101] Add support for AXS101 SDP (software development platform)")


How should we proceed with this patch?

--
Thanks,
Sasha
Vineet Gupta Nov. 21, 2018, 5:40 p.m. | #2
On 11/20/18 2:30 AM, Alexey Brodkin wrote:
> By default NFSv3 doesn't support ACL (Access Control Lists)
> which might be quite convenient to have so that
> mounted NFS behaves exactly as any other local file-system.
>
> In particular missing support of ACL makes umask useless.
> This among other thigs fixes Glibc's "nptl/tst-umask1".
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Cupertino Miranda <cmiranda@synopsys.com>
> Cc: stable@vger.kernel.org

What is this fixing in the kernel, for this to be stable backported  ?

> ---
>  arch/arc/configs/axs101_defconfig          | 1 +
>  arch/arc/configs/axs103_defconfig          | 1 +
>  arch/arc/configs/axs103_smp_defconfig      | 1 +
>  arch/arc/configs/hsdk_defconfig            | 1 +
>  arch/arc/configs/nps_defconfig             | 1 +
>  arch/arc/configs/nsimosci_defconfig        | 1 +
>  arch/arc/configs/nsimosci_hs_defconfig     | 1 +
>  arch/arc/configs/nsimosci_hs_smp_defconfig | 1 +
>  arch/arc/configs/vdk_hs38_defconfig        | 1 +
>  arch/arc/configs/vdk_hs38_smp_defconfig    | 1 +

I understand a sweeping change is easy, more consistent so a good guiding
principel in general. But really all these defconfigs need NFS ? We keep on
increasing the bloat with this. IMHO we should update only relevant defconfigs.

>  10 files changed, 10 insertions(+)
>
> diff --git a/arch/arc/configs/axs101_defconfig b/arch/arc/configs/axs101_defconfig
> index 41bc08be6a3b..8c23bd086cd0 100644
> --- a/arch/arc/configs/axs101_defconfig
> +++ b/arch/arc/configs/axs101_defconfig
> @@ -95,6 +95,7 @@ CONFIG_VFAT_FS=y
>  CONFIG_NTFS_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
> diff --git a/arch/arc/configs/axs103_defconfig b/arch/arc/configs/axs103_defconfig
> index 1e1c4a8011b5..666314fffc60 100644
> --- a/arch/arc/configs/axs103_defconfig
> +++ b/arch/arc/configs/axs103_defconfig
> @@ -94,6 +94,7 @@ CONFIG_VFAT_FS=y
>  CONFIG_NTFS_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
> diff --git a/arch/arc/configs/axs103_smp_defconfig b/arch/arc/configs/axs103_smp_defconfig
> index 6b0c0cfd5c30..429832b8560b 100644
> --- a/arch/arc/configs/axs103_smp_defconfig
> +++ b/arch/arc/configs/axs103_smp_defconfig
> @@ -97,6 +97,7 @@ CONFIG_VFAT_FS=y
>  CONFIG_NTFS_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
> diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
> index 1dec2b4bc5e6..2a1d2cbfee1a 100644
> --- a/arch/arc/configs/hsdk_defconfig
> +++ b/arch/arc/configs/hsdk_defconfig
> @@ -65,6 +65,7 @@ CONFIG_EXT3_FS=y
>  CONFIG_VFAT_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
> diff --git a/arch/arc/configs/nps_defconfig b/arch/arc/configs/nps_defconfig
> index 31ba224bbfb4..ae7a0d8be98d 100644
> --- a/arch/arc/configs/nps_defconfig
> +++ b/arch/arc/configs/nps_defconfig
> @@ -73,6 +73,7 @@ CONFIG_PROC_KCORE=y
>  CONFIG_TMPFS=y
>  # CONFIG_MISC_FILESYSTEMS is not set
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_ROOT_NFS=y
>  CONFIG_DEBUG_INFO=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
> diff --git a/arch/arc/configs/nsimosci_defconfig b/arch/arc/configs/nsimosci_defconfig
> index f14eeff7d308..ad77f20e5aa6 100644
> --- a/arch/arc/configs/nsimosci_defconfig
> +++ b/arch/arc/configs/nsimosci_defconfig
> @@ -66,5 +66,6 @@ CONFIG_EXT2_FS_XATTR=y
>  CONFIG_TMPFS=y
>  # CONFIG_MISC_FILESYSTEMS is not set
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
>  # CONFIG_ENABLE_MUST_CHECK is not set
> diff --git a/arch/arc/configs/nsimosci_hs_defconfig b/arch/arc/configs/nsimosci_hs_defconfig
> index 025298a48305..1638e5bc9672 100644
> --- a/arch/arc/configs/nsimosci_hs_defconfig
> +++ b/arch/arc/configs/nsimosci_hs_defconfig
> @@ -65,5 +65,6 @@ CONFIG_EXT2_FS_XATTR=y
>  CONFIG_TMPFS=y
>  # CONFIG_MISC_FILESYSTEMS is not set
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
>  # CONFIG_ENABLE_MUST_CHECK is not set
> diff --git a/arch/arc/configs/nsimosci_hs_smp_defconfig b/arch/arc/configs/nsimosci_hs_smp_defconfig
> index df7b77b13b82..11cfbdb0f441 100644
> --- a/arch/arc/configs/nsimosci_hs_smp_defconfig
> +++ b/arch/arc/configs/nsimosci_hs_smp_defconfig
> @@ -76,6 +76,7 @@ CONFIG_EXT2_FS_XATTR=y
>  CONFIG_TMPFS=y
>  # CONFIG_MISC_FILESYSTEMS is not set
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
>  # CONFIG_ENABLE_MUST_CHECK is not set
>  CONFIG_FTRACE=y
> diff --git a/arch/arc/configs/vdk_hs38_defconfig b/arch/arc/configs/vdk_hs38_defconfig
> index db47c3541f15..1e59a2e9c602 100644
> --- a/arch/arc/configs/vdk_hs38_defconfig
> +++ b/arch/arc/configs/vdk_hs38_defconfig
> @@ -85,6 +85,7 @@ CONFIG_NTFS_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_JFFS2_FS=y
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
> diff --git a/arch/arc/configs/vdk_hs38_smp_defconfig b/arch/arc/configs/vdk_hs38_smp_defconfig
> index a8ac5e917d9a..b5c3f6c54b03 100644
> --- a/arch/arc/configs/vdk_hs38_smp_defconfig
> +++ b/arch/arc/configs/vdk_hs38_smp_defconfig
> @@ -90,6 +90,7 @@ CONFIG_NTFS_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_JFFS2_FS=y
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
Alexey Brodkin Nov. 21, 2018, 7:01 p.m. | #3
Hi Vineet,

> -----Original Message-----
> From: Vineet Gupta
> Sent: Wednesday, November 21, 2018 8:40 PM
> To: Alexey Brodkin <abrodkin@synopsys.com>; linux-snps-arc@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org; Cupertino Miranda <cmiranda@synopsys.com>; stable@vger.kernel.org
> Subject: Re: [PATCH] arc: [devboards] Add support of NFSv3 ACL
> 
> On 11/20/18 2:30 AM, Alexey Brodkin wrote:
> > By default NFSv3 doesn't support ACL (Access Control Lists)
> > which might be quite convenient to have so that
> > mounted NFS behaves exactly as any other local file-system.
> >
> > In particular missing support of ACL makes umask useless.
> > This among other thigs fixes Glibc's "nptl/tst-umask1".
> >
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Cc: Cupertino Miranda <cmiranda@synopsys.com>
> > Cc: stable@vger.kernel.org
> 
> What is this fixing in the kernel, for this to be stable backported  ?

It fixing not kernel problem indeed but user-space providing
complete ACL-enabled NFS share support. IMHO we should have had
that enabled with basic NFS support back in the day.

Part of the problem is ACL is not an essential part of NFSv3 spec and so
it is implemented as an option though I don't see a lot of sense in having
incomplete UNIX file-system even though for most of cases it works OK.

> > ---
> >  arch/arc/configs/axs101_defconfig          | 1 +
> >  arch/arc/configs/axs103_defconfig          | 1 +
> >  arch/arc/configs/axs103_smp_defconfig      | 1 +
> >  arch/arc/configs/hsdk_defconfig            | 1 +
> >  arch/arc/configs/nps_defconfig             | 1 +
> >  arch/arc/configs/nsimosci_defconfig        | 1 +
> >  arch/arc/configs/nsimosci_hs_defconfig     | 1 +
> >  arch/arc/configs/nsimosci_hs_smp_defconfig | 1 +
> >  arch/arc/configs/vdk_hs38_defconfig        | 1 +
> >  arch/arc/configs/vdk_hs38_smp_defconfig    | 1 +
> 
> I understand a sweeping change is easy, more consistent so a good guiding
> principel in general. But really all these defconfigs need NFS ? We keep on
> increasing the bloat with this. IMHO we should update only relevant defconfigs.

Well my point is in having similarly equipped platforms so that we may rely on
results we're getting on all of them. Thus all platforms supporting networking
got that update.

Maybe NPS is not that important as we most probably not going to use it
for verification of anything so this one could be dropped.

Speaking about bloat...
------------------------------------->8-----------------------------------
# git grep NFS torvalds/master arch/arc/configs/ | grep nsim_
torvalds/master:arch/arc/configs/nsim_700_defconfig:57:CONFIG_NFS_FS=y
torvalds/master:arch/arc/configs/nsim_hs_defconfig:58:CONFIG_NFS_FS=y
torvalds/master:arch/arc/configs/nsim_hs_smp_defconfig:57:CONFIG_NFS_FS=y
------------------------------------->8-----------------------------------

It's a nonsense I guess as obviously there's no way to have networking on
pure nSIM platforms, right? And that I'm going to clean-up in a separate patch.

As for other boards I realize that we add more config options over time
but that's how we make them more useful and capable.
Moreover since we're talking about _defconfigs_ here I guess there're
many other options we don't touch but they still change so over time
we still cannot compare the same defconfigs as apples vs apples.

-Alexey
Vineet Gupta Nov. 21, 2018, 7:27 p.m. | #4
On 11/20/18 2:30 AM, Alexey Brodkin wrote:
> By default NFSv3 doesn't support ACL (Access Control Lists)
> which might be quite convenient to have so that
> mounted NFS behaves exactly as any other local file-system.
>
> In particular missing support of ACL makes umask useless.
> This among other thigs fixes Glibc's "nptl/tst-umask1".
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Cupertino Miranda <cmiranda@synopsys.com>
> Cc: stable@vger.kernel.org

Applied, with stable restricted to 4.14+

Patch

diff --git a/arch/arc/configs/axs101_defconfig b/arch/arc/configs/axs101_defconfig
index 41bc08be6a3b..8c23bd086cd0 100644
--- a/arch/arc/configs/axs101_defconfig
+++ b/arch/arc/configs/axs101_defconfig
@@ -95,6 +95,7 @@  CONFIG_VFAT_FS=y
 CONFIG_NTFS_FS=y
 CONFIG_TMPFS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/axs103_defconfig b/arch/arc/configs/axs103_defconfig
index 1e1c4a8011b5..666314fffc60 100644
--- a/arch/arc/configs/axs103_defconfig
+++ b/arch/arc/configs/axs103_defconfig
@@ -94,6 +94,7 @@  CONFIG_VFAT_FS=y
 CONFIG_NTFS_FS=y
 CONFIG_TMPFS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/axs103_smp_defconfig b/arch/arc/configs/axs103_smp_defconfig
index 6b0c0cfd5c30..429832b8560b 100644
--- a/arch/arc/configs/axs103_smp_defconfig
+++ b/arch/arc/configs/axs103_smp_defconfig
@@ -97,6 +97,7 @@  CONFIG_VFAT_FS=y
 CONFIG_NTFS_FS=y
 CONFIG_TMPFS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
index 1dec2b4bc5e6..2a1d2cbfee1a 100644
--- a/arch/arc/configs/hsdk_defconfig
+++ b/arch/arc/configs/hsdk_defconfig
@@ -65,6 +65,7 @@  CONFIG_EXT3_FS=y
 CONFIG_VFAT_FS=y
 CONFIG_TMPFS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/nps_defconfig b/arch/arc/configs/nps_defconfig
index 31ba224bbfb4..ae7a0d8be98d 100644
--- a/arch/arc/configs/nps_defconfig
+++ b/arch/arc/configs/nps_defconfig
@@ -73,6 +73,7 @@  CONFIG_PROC_KCORE=y
 CONFIG_TMPFS=y
 # CONFIG_MISC_FILESYSTEMS is not set
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_ROOT_NFS=y
 CONFIG_DEBUG_INFO=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/nsimosci_defconfig b/arch/arc/configs/nsimosci_defconfig
index f14eeff7d308..ad77f20e5aa6 100644
--- a/arch/arc/configs/nsimosci_defconfig
+++ b/arch/arc/configs/nsimosci_defconfig
@@ -66,5 +66,6 @@  CONFIG_EXT2_FS_XATTR=y
 CONFIG_TMPFS=y
 # CONFIG_MISC_FILESYSTEMS is not set
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
 # CONFIG_ENABLE_MUST_CHECK is not set
diff --git a/arch/arc/configs/nsimosci_hs_defconfig b/arch/arc/configs/nsimosci_hs_defconfig
index 025298a48305..1638e5bc9672 100644
--- a/arch/arc/configs/nsimosci_hs_defconfig
+++ b/arch/arc/configs/nsimosci_hs_defconfig
@@ -65,5 +65,6 @@  CONFIG_EXT2_FS_XATTR=y
 CONFIG_TMPFS=y
 # CONFIG_MISC_FILESYSTEMS is not set
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
 # CONFIG_ENABLE_MUST_CHECK is not set
diff --git a/arch/arc/configs/nsimosci_hs_smp_defconfig b/arch/arc/configs/nsimosci_hs_smp_defconfig
index df7b77b13b82..11cfbdb0f441 100644
--- a/arch/arc/configs/nsimosci_hs_smp_defconfig
+++ b/arch/arc/configs/nsimosci_hs_smp_defconfig
@@ -76,6 +76,7 @@  CONFIG_EXT2_FS_XATTR=y
 CONFIG_TMPFS=y
 # CONFIG_MISC_FILESYSTEMS is not set
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
 # CONFIG_ENABLE_MUST_CHECK is not set
 CONFIG_FTRACE=y
diff --git a/arch/arc/configs/vdk_hs38_defconfig b/arch/arc/configs/vdk_hs38_defconfig
index db47c3541f15..1e59a2e9c602 100644
--- a/arch/arc/configs/vdk_hs38_defconfig
+++ b/arch/arc/configs/vdk_hs38_defconfig
@@ -85,6 +85,7 @@  CONFIG_NTFS_FS=y
 CONFIG_TMPFS=y
 CONFIG_JFFS2_FS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/vdk_hs38_smp_defconfig b/arch/arc/configs/vdk_hs38_smp_defconfig
index a8ac5e917d9a..b5c3f6c54b03 100644
--- a/arch/arc/configs/vdk_hs38_smp_defconfig
+++ b/arch/arc/configs/vdk_hs38_smp_defconfig
@@ -90,6 +90,7 @@  CONFIG_NTFS_FS=y
 CONFIG_TMPFS=y
 CONFIG_JFFS2_FS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set