From patchwork Fri Nov 21 12:48:12 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Komuro X-Patchwork-Id: 10001 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id F14AEDDEEF for ; Fri, 21 Nov 2008 23:58:08 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbYKUM6F (ORCPT ); Fri, 21 Nov 2008 07:58:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752970AbYKUM6D (ORCPT ); Fri, 21 Nov 2008 07:58:03 -0500 Received: from defg501.nifty.com ([202.248.238.128]:33326 "EHLO defg501.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752848AbYKUM6B (ORCPT ); Fri, 21 Nov 2008 07:58:01 -0500 Received: from userg502.nifty.com (userg502p.nifty.com [172.22.128.82])by defg501.nifty.com with ESMTP id mALCrjTc011895 for ; Fri, 21 Nov 2008 21:53:45 +0900 Received: from localhost.localdomain (eaoska167197.adsl.ppp.infoweb.ne.jp [219.116.16.197])by userg502.nifty.com with SMTP id mALCqwT6022449; Fri, 21 Nov 2008 21:52:59 +0900 DomainKey-Signature: a=rsa-sha1; s=userg502; d=nifty.com; c=nofws; q=dns; h=date:from:to:cc:subject:message-id:in-reply-to:references: x-mailer:mime-version:content-type:content-transfer-encoding; b=qvFmU65Ctd2mED3d4zYZgx3NoMim8punckmZ+zLsy1DHZFB7Mc0eYoxbCGoRXM/N2 DII/BXN8KsaofjERfPzVA== X-Nifty-SrcIP: [219.116.16.197] Date: Fri, 21 Nov 2008 21:48:12 +0900 From: Komuro To: Cord Walter Cc: netdev@vger.kernel.org, linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: axnet_cs / pcnet_cs: moving PCMCIA_DEVICE_PROD_ID for Netgear FA411 Message-Id: <20081121214812.b03d7166.komurojun-mbn@nifty.com> In-Reply-To: <4925F6F1.9010305@gmx.de> References: <4925F6F1.9010305@gmx.de> X-Mailer: Sylpheed 2.3.1 (GTK+ 2.10.11; i386-redhat-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 21 Nov 2008 00:46:57 +0100 Cord Walter wrote: > after noticing that my Netgear FA411 (PCMCIA-NIC) [1] stopped working with > the release of the 2.6.25 kernel (sidux-version), You are right. My patch has a bug. The patch below fixes this problem. By the way, (1) Does your FA411 work properly with the pcnet_cs driver before? (2) Please post the full-dmesg (axnet_cs). Best Regards Komuro > Hi, > > after noticing that my Netgear FA411 (PCMCIA-NIC) [1] stopped working with > the release of the 2.6.25 kernel (sidux-version), I checked the > respective driver sources and noticed that the pcnet_cs driver bailed > out with "use axnet_cs instead" for the Netgear FA411, but axnet_cs > doesn't claim this ID. > > I compiled a kernel with the PCMCIA-ID for the netgear card moved to > axnet_cs from pcnet_cs which worked. I then contacted sidux-kernel > maintainer Stefan Lippers-Hollmann who turned the info into this patch > and integrated it into the kernel: > > > > This works for me and AFAIK there were no reports of any breakage for > other devices on sidux-support. > > This looks like a trivial patch, but since I have very limited > experience with kernel modifications I might be woefully wrong there. > But if there are no side effects of this patch, is it possible to get it > into the official kernel? > > I can provide more detailed information on the affected hardware if > necessary. > > -cord > > > [1] > Socket 1 Device 0: [axnet_cs] (bus ID: 1.0) > Configuration: state: on > Product Name: NETGEAR FA411 Fast Ethernet > Identification: manf_id: 0x0149 card_id: 0x0411 > function: 6 (network) > prod_id(1): "NETGEAR" (0x9aa79dc3) > prod_id(2): "FA411" (0x40fad875) > prod_id(3): "Fast Ethernet" (0xb4be14e3) > prod_id(4): --- (---) > -- > Cord Walter > email: cord.walter@gmx.de > > Weil es niemanden etwas angeht, dass ich nichts zu verbergen habe: > http://www.gnupg.org/ > http://www.truecrypt.org/ > ...und überhaupt: http://www.FreiheitstattAngst.de > > > Signed-off-by: Cord Walter Signed-off-by: Komuro Signed-off-by: Cord Walter Signed-off-by: Komuro --- linux-2.6.28-rc6/drivers/net/pcmcia/pcnet_cs.c.orig 2008-11-21 21:39:08.000000000 +0900 +++ linux-2.6.28-rc6/drivers/net/pcmcia/pcnet_cs.c 2008-11-21 21:39:24.000000000 +0900 @@ -587,7 +587,7 @@ static int pcnet_config(struct pcmcia_de } if ((link->conf.ConfigBase == 0x03c0) - && (link->manf_id == 0x149) && (link->card_id = 0xc1ab)) { + && (link->manf_id == 0x149) && (link->card_id == 0xc1ab)) { printk(KERN_INFO "pcnet_cs: this is an AX88190 card!\n"); printk(KERN_INFO "pcnet_cs: use axnet_cs instead.\n"); goto failed;