| Message ID | 20181119205955.32042-7-boris.brezillon@bootlin.com |
|---|---|
| State | Superseded |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | mtd/sf: Various fixes | expand |
Hello Boris, Am 19.11.2018 um 21:59 schrieb Boris Brezillon: > strstr() does not guarantee that the string we're searching for is > placed at the beginning. Use strncmp() instead. > > Fixes: 5db66b3aee6f ("cmd: mtd: add 'mtd' command") > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > --- > Changes in v3: > - None > > Changes in v2: > - New patch > --- > drivers/mtd/mtd_uboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Heiko Schocher <hs@denx.de> bye, Heiko
diff --git a/drivers/mtd/mtd_uboot.c b/drivers/mtd/mtd_uboot.c index c4434d70520d..d551aee20203 100644 --- a/drivers/mtd/mtd_uboot.c +++ b/drivers/mtd/mtd_uboot.c @@ -215,7 +215,7 @@ int mtd_probe_devices(void) return 0; /* Start the parsing by ignoring the extra 'mtdparts=' prefix, if any */ - if (strstr(mtdparts, "mtdparts=")) + if (!strncmp(mtdparts, "mtdparts=", sizeof("mtdparts=") - 1)) mtdparts += 9; /* For each MTD device in mtdparts */
strstr() does not guarantee that the string we're searching for is placed at the beginning. Use strncmp() instead. Fixes: 5db66b3aee6f ("cmd: mtd: add 'mtd' command") Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> --- Changes in v3: - None Changes in v2: - New patch --- drivers/mtd/mtd_uboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)