mbox series

[SRU,Bionic,0/1] xfrm: Verify MAC header exists before overwriting eth_hdr(skb)->h_proto

Message ID cover.1538493520.git.joseph.salisbury@canonical.com
Headers show
Series xfrm: Verify MAC header exists before overwriting eth_hdr(skb)->h_proto | expand

Message

Joseph Salisbury Oct. 11, 2018, 7:49 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1795653

== SRU Justification ==
Commit 87cdf3148b11 fixes a regression introduced by commit
5efec5c655dd.  However, it has not never landed in Bionic.   Requesting
this commit in Bionic, so we don't have to wait for it to come down from
upstream stable.


== Fix ==
87cdf3148b11 ("xfrm: Verify MAC header exists before overwriting eth_hdr(skb)->h_proto")

== Regression Potential ==
Low.  This commit fixes and existing regression by making sure teh MAC
header exists.

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.


Yossi Kuperman (1):
  xfrm: Verify MAC header exists before overwriting
    eth_hdr(skb)->h_proto

 net/ipv4/xfrm4_mode_tunnel.c | 3 ++-
 net/ipv6/xfrm6_mode_tunnel.c | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

Khalid Elmously Oct. 12, 2018, 7:29 a.m. UTC | #1
On 2018-10-11 15:49:18 , Joseph Salisbury wrote:
> BugLink: https://bugs.launchpad.net/bugs/1795653
> 
> == SRU Justification ==
> Commit 87cdf3148b11 fixes a regression introduced by commit
> 5efec5c655dd.  However, it has not never landed in Bionic.   Requesting
> this commit in Bionic, so we don't have to wait for it to come down from
> upstream stable.
> 
> 
> == Fix ==
> 87cdf3148b11 ("xfrm: Verify MAC header exists before overwriting eth_hdr(skb)->h_proto")
> 
> == Regression Potential ==
> Low.  This commit fixes and existing regression by making sure teh MAC
> header exists.
> 
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> 
> Yossi Kuperman (1):
>   xfrm: Verify MAC header exists before overwriting
>     eth_hdr(skb)->h_proto
> 
>  net/ipv4/xfrm4_mode_tunnel.c | 3 ++-
>  net/ipv6/xfrm6_mode_tunnel.c | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
Khalid Elmously Oct. 22, 2018, 7:27 a.m. UTC | #2
On 2018-10-11 15:49:18 , Joseph Salisbury wrote:
> BugLink: https://bugs.launchpad.net/bugs/1795653
> 
> == SRU Justification ==
> Commit 87cdf3148b11 fixes a regression introduced by commit
> 5efec5c655dd.  However, it has not never landed in Bionic.   Requesting
> this commit in Bionic, so we don't have to wait for it to come down from
> upstream stable.
> 
> 
> == Fix ==
> 87cdf3148b11 ("xfrm: Verify MAC header exists before overwriting eth_hdr(skb)->h_proto")
> 
> == Regression Potential ==
> Low.  This commit fixes and existing regression by making sure teh MAC
> header exists.
> 
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> 
> Yossi Kuperman (1):
>   xfrm: Verify MAC header exists before overwriting
>     eth_hdr(skb)->h_proto
> 
>  net/ipv4/xfrm4_mode_tunnel.c | 3 ++-
>  net/ipv6/xfrm6_mode_tunnel.c | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team