| Message ID | 20180925124629.20710-1-brgl@bgdev.pl |
|---|---|
| Headers | show |
| Series | devres: provide and use devm_kstrdup_const() | expand |
On 25/09/18 13:46, Bartosz Golaszewski wrote: > This series implements devm_kstrdup_const() together with some > prerequisite changes and uses it in pmc-atom driver. Is anyone expecting me to review this series, or am I just here because I once made a couple of entirely unrelated changes to device.h? Robin. > v1 -> v2: > - fixed the changelog in the patch implementing devm_kstrdup_const() > - fixed the kernel doc > - moved is_kernel_rodata() to asm-generic/sections.h > - fixed constness > > v2 -> v3: > - rebased on top of 4.19-rc5 as there were some conflicts in the > pmc-atom driver > - collected Reviewed-by tags > > v3 -> v4: > - Andy NAK'ed patch 4/4 so I added a different example > - collected more tags > > Bartosz Golaszewski (4): > devres: constify p in devm_kfree() > mm: move is_kernel_rodata() to asm-generic/sections.h > devres: provide devm_kstrdup_const() > mailbox: tegra-hsp: use devm_kstrdup_const() > > drivers/base/devres.c | 43 ++++++++++++++++++++++++++++++++-- > drivers/mailbox/tegra-hsp.c | 41 +++++++------------------------- > include/asm-generic/sections.h | 14 +++++++++++ > include/linux/device.h | 5 +++- > mm/util.c | 7 ------ > 5 files changed, 68 insertions(+), 42 deletions(-) >
On Tue, 2018-09-25 at 13:51 +0100, Robin Murphy wrote: > On 25/09/18 13:46, Bartosz Golaszewski wrote: > > This series implements devm_kstrdup_const() together with some > > prerequisite changes and uses it in pmc-atom driver. > > Is anyone expecting me to review this series, Probably not. > or am I just here because > I once made a couple of entirely unrelated changes to device.h? Most likely yes. It is likely that Bartosz should update his use of the get_maintainer.pl script to add "--nogit --nogit-fallback" so drive-by patch submitters are not also cc'd on these sorts of series. $ ./scripts/get_maintainer.pl -f \ drivers/base/devres.c \ drivers/mailbox/tegra-hsp.c \ include/asm-generic/sections.h \ include/linux/device.h \ mm/util.c | \ wc -l 26 $ ./scripts/get_maintainer.pl -f --nogit --nogit-fallback \ drivers/base/devres.c \ drivers/mailbox/tegra-hsp.c \ include/asm-generic/sections.h \ include/linux/device.h \ mm/util.c | \ wc -l 10
wt., 25 wrz 2018 o 17:48 Joe Perches <joe@perches.com> napisał(a): > > On Tue, 2018-09-25 at 13:51 +0100, Robin Murphy wrote: > > On 25/09/18 13:46, Bartosz Golaszewski wrote: > > > This series implements devm_kstrdup_const() together with some > > > prerequisite changes and uses it in pmc-atom driver. > > > > Is anyone expecting me to review this series, > > Probably not. > > > or am I just here because > > I once made a couple of entirely unrelated changes to device.h? > > Most likely yes. > > It is likely that Bartosz should update his use of the > get_maintainer.pl script to add "--nogit --nogit-fallback" > so drive-by patch submitters are not also cc'd on these > sorts of series. > > $ ./scripts/get_maintainer.pl -f \ > drivers/base/devres.c \ > drivers/mailbox/tegra-hsp.c \ > include/asm-generic/sections.h \ > include/linux/device.h \ > mm/util.c | \ > wc -l > 26 > > $ ./scripts/get_maintainer.pl -f --nogit --nogit-fallback \ > drivers/base/devres.c \ > drivers/mailbox/tegra-hsp.c \ > include/asm-generic/sections.h \ > include/linux/device.h \ > mm/util.c | \ > wc -l > 10 > > Hi, sorry for that. Got it and will use next time. Bartosz