mbox series

[LINUX,v11,0/3] Add support for Arasan NAND Flash controller

Message ID 1537878031-22253-1-git-send-email-naga.sureshkumar.relli@xilinx.com
Headers show
Series Add support for Arasan NAND Flash controller | expand

Message

Naga Sureshkumar Relli Sept. 25, 2018, 12:20 p.m. UTC 
This patch series adds the basic driver support for Arasan NAND Flash controller.
We are reinitiating the patch series by fixing the comments given by Miquel and Boris.
Major changes are exec_op() implementation related.
Rebased to 4.19 nand tree.
Tested MT29F32G08ABCDBJ4.

As suggested by Boris, it also adds a new varaible called mode in
struct nand_sdr_timings, which will give directly the sdr operating
mode. and it is useful for some controllers, where we can configure
direclty the operating mode instead of timings.

Naga Sureshkumar Relli (3):
  dt-bindings: mtd: arasan: Add device tree binding documentation
  mtd: rawnand: Add an option to get sdr timing mode number
  mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

 .../devicetree/bindings/mtd/arasan_nand.txt        |   33 +
 drivers/mtd/nand/raw/Kconfig                       |    7 +
 drivers/mtd/nand/raw/Makefile                      |    1 +
 drivers/mtd/nand/raw/arasan_nand.c                 | 1324 ++++++++++++++++++++
 drivers/mtd/nand/raw/nand_timings.c                |    6 +
 include/linux/mtd/rawnand.h                        |    2 +
 6 files changed, 1373 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mtd/arasan_nand.txt
 create mode 100644 drivers/mtd/nand/raw/arasan_nand.c

Comments

Miquel Raynal Oct. 29, 2018, 9:51 a.m. UTC | #1 
Hi Naga,

Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com> wrote on
Tue, 25 Sep 2018 17:50:28 +0530:

> This patch series adds the basic driver support for Arasan NAND Flash controller.
> We are reinitiating the patch series by fixing the comments given by Miquel and Boris.
> Major changes are exec_op() implementation related.
> Rebased to 4.19 nand tree.
> Tested MT29F32G08ABCDBJ4.
> 
> As suggested by Boris, it also adds a new varaible called mode in
> struct nand_sdr_timings, which will give directly the sdr operating
> mode. and it is useful for some controllers, where we can configure
> direclty the operating mode instead of timings.
> 

Unless I missed something there are still comments from Boris pending?
I will wait for your v12 to give this driver another shot.

Thanks,
Miquèl
Naga Sureshkumar Relli Oct. 29, 2018, 1:05 p.m. UTC | #2 
Hi Miquel,

> -----Original Message-----
> From: Miquel Raynal [mailto:miquel.raynal@bootlin.com]
> Sent: Monday, October 29, 2018 3:21 PM
> To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> Cc: boris.brezillon@bootlin.com; richard@nod.at; dwmw2@infradead.org;
> computersforpeace@gmail.com; marek.vasut@gmail.com; linux-mtd@lists.infradead.org;
> linux-kernel@vger.kernel.org; Michal Simek <michals@xilinx.com>;
> nagasuresh12@gmail.com
> Subject: Re: [LINUX PATCH v11 0/3] Add support for Arasan NAND Flash controller
> 
> Hi Naga,
> 
> Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com> wrote on Tue, 25 Sep 2018
> 17:50:28 +0530:
> 
> > This patch series adds the basic driver support for Arasan NAND Flash controller.
> > We are reinitiating the patch series by fixing the comments given by Miquel and Boris.
> > Major changes are exec_op() implementation related.
> > Rebased to 4.19 nand tree.
> > Tested MT29F32G08ABCDBJ4.
> >
> > As suggested by Boris, it also adds a new varaible called mode in
> > struct nand_sdr_timings, which will give directly the sdr operating
> > mode. and it is useful for some controllers, where we can configure
> > direclty the operating mode instead of timings.
> >
> 
> Unless I missed something there are still comments from Boris pending?
> I will wait for your v12 to give this driver another shot.
shall I send the v12 on top of nand/for-4.20?

Thanks,
Naga Sureshkumar Relli
> 
> Thanks,
> Miquèl
Miquel Raynal Oct. 29, 2018, 1:22 p.m. UTC | #3 
Hi Naga,

Naga Sureshkumar Relli <nagasure@xilinx.com> wrote on Mon, 29 Oct 2018
13:05:47 +0000:

> Hi Miquel,
> 
> > -----Original Message-----
> > From: Miquel Raynal [mailto:miquel.raynal@bootlin.com]
> > Sent: Monday, October 29, 2018 3:21 PM
> > To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> > Cc: boris.brezillon@bootlin.com; richard@nod.at; dwmw2@infradead.org;
> > computersforpeace@gmail.com; marek.vasut@gmail.com; linux-mtd@lists.infradead.org;
> > linux-kernel@vger.kernel.org; Michal Simek <michals@xilinx.com>;
> > nagasuresh12@gmail.com
> > Subject: Re: [LINUX PATCH v11 0/3] Add support for Arasan NAND Flash controller
> > 
> > Hi Naga,
> > 
> > Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com> wrote on Tue, 25 Sep 2018
> > 17:50:28 +0530:
> >   
> > > This patch series adds the basic driver support for Arasan NAND Flash controller.
> > > We are reinitiating the patch series by fixing the comments given by Miquel and Boris.
> > > Major changes are exec_op() implementation related.
> > > Rebased to 4.19 nand tree.
> > > Tested MT29F32G08ABCDBJ4.
> > >
> > > As suggested by Boris, it also adds a new varaible called mode in
> > > struct nand_sdr_timings, which will give directly the sdr operating
> > > mode. and it is useful for some controllers, where we can configure
> > > direclty the operating mode instead of timings.
> > >  
> > 
> > Unless I missed something there are still comments from Boris pending?
> > I will wait for your v12 to give this driver another shot.  
> shall I send the v12 on top of nand/for-4.20?

Yes please, or wait for -rc1 to be out. There is no rush.


Thanks,
Miquèl