mbox series

[ovs-dev,0/2] Fix Python C extension unicode issues

Message ID 1537397249-30180-1-git-send-email-twilson@redhat.com
Headers show
Series Fix Python C extension unicode issues | expand

Message

Terry Wilson Sept. 19, 2018, 10:47 p.m. UTC 
There are some unicode issues with the Python JSON C extension.
These crept in because the tests don't actually run against it
except under some pretty specific conditions. This patch set
runs the Python-releated tests against both backends and
successfully skips the new tests if the JSON C extension isn't
built.

The unicode issues are worked around, though I'm not super
happy with how. It might be better to make the pure-Python
JSON parser operate on bytes() instead of unicode(), but I was
afraid that would end up being a lot more work, especially
given the differences with Python 2 and Python 3.

Comments

Ben Pfaff Sept. 25, 2018, 10:37 p.m. UTC | #1 
Thanks for improving OVS and its tests.

When I apply these I get flake8 complaints:

../tests/test-json.py:69:80: E501 line too long (86 > 79 characters)
../tests/test-json.py:85:27: F821 undefined name 'error'

Can you do a v2 to avoid those?