Message ID | 1536029091-4426-1-git-send-email-climbbb.kim@gmail.com |
---|---|
Headers | show
Return-Path: <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PpEc191I"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VhQlB8Um"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B5h6c8Nz9s4s for <incoming@patchwork.ozlabs.org>; Tue, 4 Sep 2018 12:45:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=4/MjgkqS+bUxx7gC/xN8V62PYSiPrT4T4UO+GY4O3ts=; b=PpE c191IDIiDpSi0/IvApXanfBmHes1Qft8U8MCjRJDyYFa22gzcBdeb7OUYuThXK8Ez3T5c7RcO08Gx Zz7gJCezmwywNWpvtSHXp757aAPqqRESiRJDr+xdSzjuyQLhq5tiT5COnuI8DscCv0oPnAwv0WATb 3Gl+8KtY44uDDwkxIYKWKyu8unOKvwk+y5ljPGNYNcN8lMO+l7tDRGYnoKllwTDPYpXqeeQsdfc9+ ZgDjcHrY2ABnQrxhxukG6KpvrcaA6E06mj/FH8HqvKp3h0eBuO4r8usTf0tt4wWafxwREhy4dg1rg RPfIUjASWOKDfRi7Ywq50B3y1oXoGOg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LB-00052l-Fa; Tue, 04 Sep 2018 02:45:17 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1L6-0003wM-Pq for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:14 +0000 Received: by mail-pl1-x642.google.com with SMTP id b12-v6so882148plr.8 for <linux-um@lists.infradead.org>; Mon, 03 Sep 2018 19:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=iMhPemz6msZZyzFD19nUQgO5wHb0URGKKu4niDcK1R4=; b=VhQlB8UmNKA3oOJeJao1OY6bcYF/k7cLJxCEGlWQKLusZk+UVP/bcheK8G9PXklcN7 GHPJoNmtkLi5EUoYRvxqr2OAKnTDmSMtV8fwMTzhs6HmvfGwyDF4thEDAWs/jg+zeY68 cmmRJtbCtwbqUk5fNyPyioJbmkrcHrlA2imk/14bpJ/EC8V0erF97VnpzqYYjNPhG2Pe +hG4nLCHcBSpm41n8/4w811VtkX9nqM/3W/x9uAY4NgesnSC45G9xZOuM9EmdNvDtgZP /MCuCKXlIYenELMvi8CNL9njfnB0V2CNOdirUms0z8+0jqNImBiQd4Y/LaIGvdhvA/s4 zIDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=iMhPemz6msZZyzFD19nUQgO5wHb0URGKKu4niDcK1R4=; b=ObC4OsNxqMRt/dHLBOoijnMGNUZj38LyMCC1TD0DiyCZp5aGUY89tqk1BzUGtwSFYd sRVrcPdDleHT73rQ1VmJ5ZEjpAZO2DBEVOA2lZ5VpP5g2IQlrbYEfikS5g3YyUzFSLe8 GDDzvQGpYlav97As9lDlamVcdGg7S8SkB5Q5+x1gAPGp/CbckX4TFIt257xJ+qhud0NB YgYdn/IxaoZVCIJNHkdWy3vjjc+/pHCAMoTWJVcloRWAXDa4QD66g41kj5t/jZVFnvvx 568VAWShcQfyv5W0GGKqvqWbNfcf9ySsJgCDaQA+Cq+NpcbhEYCwPz5D3q1u0i0CVcAD CYDA== X-Gm-Message-State: APzg51Bdjx0KH4puELD2BYHmCihFzMTcw5y5vsG0Aj7j0MwXW30w29yO pL48amfD/NChfnArx+pE3jk2+F8Q X-Google-Smtp-Source: ANB0VdZcrlfo6X3zKVVnvfd1VPq1JqTXSvlCJj1+WppIK86F6Mh9Ss3V5vQp1cEzYWANtv9Haa30zw== X-Received: by 2002:a17:902:714f:: with SMTP id u15-v6mr32303395plm.154.1536029101535; Mon, 03 Sep 2018 19:45:01 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.44.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:01 -0700 (PDT) From: Jaejoong Kim <climbbb.kim@gmail.com> To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 00/25] Change tty_port(standard)_install's return type Date: Tue, 4 Sep 2018 11:44:26 +0900 Message-Id: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194512_875382_A63E325D X-CRM114-Status: UNSURE ( 8.87 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:642 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-um.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-um/> List-Post: <mailto:linux-um@lists.infradead.org> List-Help: <mailto:linux-um-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=subscribe> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" <linux-um-bounces@lists.infradead.org> Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
Change tty_port(standard)_install's return type
|
expand
|
Hi Jaejoong. > Change return type for tty functions. Patch No.01 > tty: Change return type to void Adding this patch first will generate a lot of warnings until all users are updated. It is usual practice to prepare all users and then apply the infrastructure changes as the last patch. Then people will not see a lot of warnings when they build something in the middle, and I guess current stack set may also generate a few mails from the 0-day build infrastructure. > isdn: i4l: isdn_tty: Change return type to void And a nitpick on the patch description. This patch do not change any return type, but it ignore the return value og tty_part_install(). Same goes for all ramaining patches. Sam
On Tue, 4 Sep 2018 11:44:26 +0900 Jaejoong Kim <climbbb.kim@gmail.com> wrote: > Many drivers with tty use the tty_stand_install(). But, there is no > need to handle the error, since it always returns 0. And what happens if another change means it can fail again. It's just a property of the current implementation that it can't. It used to fail. This seems to be a ton of unneccessary churn that will end up just having to be reversed again some day in the future. Alan