| Message ID | 1535968829-19418-1-git-send-email-tony.xie@rock-chips.com |
|---|---|
| Headers | show |
| Series | support a new type of PMIC, including two chips(rk817 and rk809) | expand |
On Mon, 03 Sep 2018, Tony Xie wrote: > The rk809 and rk817 are a Power Management IC (PMIC) for multimedia > and handheld devices. It contains the following components: > > - Regulators > - RTC > - Clocking > > Both RK809 and RK817 chips are using a similar register map, > so we can reuse the RTC and Clocking and regulators functionality. > > Signed-off-by: Tony Xie <tony.xie@rock-chips.com> > --- It's often helpful to place a Changelog in this space. > drivers/mfd/Kconfig | 6 +- > drivers/mfd/rk808.c | 218 +++++++++++++++++++++++++++++++++++++++++++++- > include/linux/mfd/rk808.h | 172 ++++++++++++++++++++++++++++++++++++ > kernel/reboot.c | 1 + > 4 files changed, 391 insertions(+), 6 deletions(-) I just reviewed v4. It looks like the review comments are still relevant.
Quoting Tony Xie (2018-09-03 03:04:00) > RK809 and RK817 are power management IC chips for multimedia products. > most of their functions and registers are same, including the clkout > funciton. > > Signed-off-by: Tony Xie <tony.xie@rock-chips.com> > --- Acked-by: Stephen Boyd <sboyd@kernel.org>
> On Mon, 03 Sep 2018, Tony Xie wrote: > >> The rk809 and rk817 are a Power Management IC (PMIC) for multimedia >> and handheld devices. It contains the following components: >> >> - Regulators >> - RTC >> - Clocking >> >> Both RK809 and RK817 chips are using a similar register map, >> so we can reuse the RTC and Clocking and regulators functionality. >> >> Signed-off-by: Tony Xie <tony.xie@rock-chips.com> >> --- > It's often helpful to place a Changelog in this space. I will output the changelog in the first mail when send-mail. > >> drivers/mfd/Kconfig | 6 +- >> drivers/mfd/rk808.c | 218 +++++++++++++++++++++++++++++++++++++++++++++- >> include/linux/mfd/rk808.h | 172 ++++++++++++++++++++++++++++++++++++ >> kernel/reboot.c | 1 + >> 4 files changed, 391 insertions(+), 6 deletions(-) > I just reviewed v4. > > It looks like the review comments are still relevant. I will commit the v5 today which includes some modification base on your comments base in the v3. >
Most of functions and registers of the rk817 and rk808 are the same, so they can share allmost all codes. Their specifications are as follows： 1) The RK809 and RK809 consist of 5 DCDCs, 9 LDOs and have the same registers for these components except dcdc5. 2) The dcdc5 is a boost dcdc for RK817 and is a buck for RK809. 3) The RK817 has one switch but The Rk809 has two. Changes in V2: 1. initialize the pm_pwroff_fn to NULL. 2. use EXPORT_SYMBOL_GPL to export pm_power_off_prepare. 3. change patch 2/3/4/5 subjects. Changes in V3： 1. change patch 4 subjects 2. replace pr_ with dev_ for printing in patch 2 3. modify switch1 and switch2 configs in patch 2 4. explain gpio information for rk809 and rk817 in patch 4 Changes in V4： 1. modify some codes for patch 2 and patch 5 according to comments 2. add reviewer mail lists for patch 3 and 4 Tony Xie (5): mfd: rk808: Add RK817 and RK809 support regulator: rk808: add RK809 and RK817 support. dt-bindings: mfd: rk808: Add binding information for RK809 and RK817. rtc: rk808: add RK809 and RK817 support. clk: RK808: add RK809 and RK817 support. Documentation/devicetree/bindings/mfd/rk808.txt | 56 ++ drivers/clk/Kconfig | 9 +- drivers/clk/clk-rk808.c | 64 ++- drivers/mfd/Kconfig | 6 +- drivers/mfd/rk808.c | 218 +++++++- drivers/regulator/Kconfig | 4 +- drivers/regulator/rk808-regulator.c | 657 +++++++++++++++++++++++- drivers/rtc/Kconfig | 4 +- drivers/rtc/rtc-rk808.c | 68 ++- include/linux/mfd/rk808.h | 175 +++++++ kernel/reboot.c | 1 + 11 files changed, 1204 insertions(+), 58 deletions(-)